[Libreoffice-commits] core.git: filter/source

Caolán McNamara caolanm at redhat.com
Tue Apr 17 09:57:12 UTC 2018


 filter/source/msfilter/msdffimp.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 08ec0144cc6c58ce9aeb4d573cee4fd46c484bcd
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue Apr 17 09:20:56 2018 +0100

    ofz#7671 Undefined-shift
    
    Change-Id: I84c6e6a3bb97d9949e9833adf14edf6bb89fe073
    Reviewed-on: https://gerrit.libreoffice.org/53018
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx
index fc5b87d6814c..2e842b106f78 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -1986,7 +1986,7 @@ void DffPropertyReader::ApplyCustomShapeGeometryAttributes( SvStream& rIn, SfxIt
                         nCenterX = nCoordWidth / 2;
                     if ( nCenterY == 2 )
                         nCenterY = nCoordHeight / 2;
-                    if ( ( nPositionY >= 0x256 ) || ( nPositionY <= 0x107 ) )   // position y
+                    if ((nPositionY >= 0x256 || nPositionY <= 0x107) && i < sizeof(sal_uInt32) * 8)   // position y
                         nAdjustmentsWhichNeedsToBeConverted |= ( 1U << i );
                     EnhancedCustomShapeParameterPair aPolar;
                     EnhancedCustomShape2d::SetEnhancedCustomShapeHandleParameter( aPolar.First,  nCenterX, bool( nFlags & SvxMSDffHandleFlags::CENTER_X_IS_SPECIAL ), true  );


More information about the Libreoffice-commits mailing list