[Libreoffice-commits] core.git: tools/CppunitTest_tools_test.mk tools/qa

Chris Sherlock chris.sherlock79 at gmail.com
Mon Apr 30 06:19:48 UTC 2018


 tools/CppunitTest_tools_test.mk  |    1 
 tools/qa/cppunit/test_minmax.cxx |   99 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 100 insertions(+)

New commits:
commit 08b437a7f1a9c5d2bc8e0667220b3446b5896d14
Author: Chris Sherlock <chris.sherlock79 at gmail.com>
Date:   Wed Apr 25 23:14:23 2018 +1000

    tools: test for MinMax
    
    Change-Id: Ifbef563c02027e69226ff6585b721c23566435ea
    Reviewed-on: https://gerrit.libreoffice.org/53451
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/tools/CppunitTest_tools_test.mk b/tools/CppunitTest_tools_test.mk
index 8cd8e7c3e9b3..2c24b21878fa 100644
--- a/tools/CppunitTest_tools_test.mk
+++ b/tools/CppunitTest_tools_test.mk
@@ -24,6 +24,7 @@ $(eval $(call gb_CppunitTest_add_exception_objects,tools_test, \
     tools/qa/cppunit/test_urlobj \
     tools/qa/cppunit/test_color \
     tools/qa/cppunit/test_rectangle \
+    tools/qa/cppunit/test_minmax \
 ))
 
 $(eval $(call gb_CppunitTest_use_sdk_api,tools_test))
diff --git a/tools/qa/cppunit/test_minmax.cxx b/tools/qa/cppunit/test_minmax.cxx
new file mode 100644
index 000000000000..390353045dfc
--- /dev/null
+++ b/tools/qa/cppunit/test_minmax.cxx
@@ -0,0 +1,99 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#include <sal/types.h>
+#include <cppunit/TestFixture.h>
+#include <cppunit/extensions/HelperMacros.h>
+#include <cppunit/plugin/TestPlugIn.h>
+
+#include <tools/helpers.hxx>
+
+namespace tools
+{
+class MinMaxTest : public CppUnit::TestFixture
+{
+public:
+    void testSignedMinMax()
+    {
+        sal_Int32 nSignedVal = -10;
+        long nMin = 1;
+        long nMax = 10;
+        CPPUNIT_ASSERT_EQUAL(static_cast<sal_Int32>(nMin),
+                             static_cast<sal_Int32>(MinMax(nSignedVal, nMin, nMax)));
+
+        nSignedVal = -10;
+        nMin = -15;
+        nMax = 10;
+        CPPUNIT_ASSERT_EQUAL(nSignedVal, static_cast<sal_Int32>(MinMax(nSignedVal, nMin, nMax)));
+
+        nSignedVal = -15;
+        nMin = -15;
+        nMax = 10;
+        CPPUNIT_ASSERT_EQUAL(nSignedVal, static_cast<sal_Int32>(MinMax(nSignedVal, nMin, nMax)));
+    }
+
+    void testUnsignedMinMax()
+    {
+        sal_uInt32 nUnsignedVal = 5;
+        long nMin = 1;
+        long nMax = 10;
+        CPPUNIT_ASSERT_EQUAL(nUnsignedVal,
+                             static_cast<sal_uInt32>(MinMax(nUnsignedVal, nMin, nMax)));
+
+        nUnsignedVal = 5;
+        nMin = 1;
+        nMax = 5;
+        CPPUNIT_ASSERT_EQUAL(nUnsignedVal,
+                             static_cast<sal_uInt32>(MinMax(nUnsignedVal, nMin, nMax)));
+
+        nUnsignedVal = 5;
+        nMin = 5;
+        nMax = 5;
+        CPPUNIT_ASSERT_EQUAL(nUnsignedVal,
+                             static_cast<sal_uInt32>(MinMax(nUnsignedVal, nMin, nMax)));
+
+        nUnsignedVal = 10;
+        nMin = -20;
+        nMax = 15;
+        CPPUNIT_ASSERT_EQUAL(nUnsignedVal,
+                             static_cast<sal_uInt32>(MinMax(nUnsignedVal, nMin, nMax)));
+
+        nUnsignedVal = 20;
+        nMin = 10;
+        nMax = 15;
+        CPPUNIT_ASSERT_EQUAL(static_cast<sal_uInt32>(nMax),
+                             static_cast<sal_uInt32>(MinMax(nUnsignedVal, nMin, nMax)));
+
+        nUnsignedVal = 5;
+        nMin = 10;
+        nMax = 15; // irrelevant, but cannot be less than nMin
+        CPPUNIT_ASSERT_EQUAL(static_cast<sal_uInt32>(nMin),
+                             static_cast<sal_uInt32>(MinMax(nUnsignedVal, nMin, nMax)));
+    }
+
+    CPPUNIT_TEST_SUITE(MinMaxTest);
+    CPPUNIT_TEST(testSignedMinMax);
+    CPPUNIT_TEST(testUnsignedMinMax);
+    CPPUNIT_TEST_SUITE_END();
+};
+
+CPPUNIT_TEST_SUITE_REGISTRATION(MinMaxTest);
+} // namespace tools
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */


More information about the Libreoffice-commits mailing list