[Libreoffice-commits] core.git: 2 commits - sw/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sun Aug 5 18:28:15 UTC 2018


 sw/source/core/unocore/unotbl.cxx |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 816da33afa4b0dcafed301880c1a12279193b95d
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Aug 5 10:31:26 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Aug 5 20:28:04 2018 +0200

    coverity#1438214 Unchecked dynamic_cast
    
    Change-Id: I68e1569835a1e981f57aabf2565f3eb2c619d296
    Reviewed-on: https://gerrit.libreoffice.org/58608
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sw/source/core/unocore/unotbl.cxx b/sw/source/core/unocore/unotbl.cxx
index 8da0b3adec3e..568009959399 100644
--- a/sw/source/core/unocore/unotbl.cxx
+++ b/sw/source/core/unocore/unotbl.cxx
@@ -2280,10 +2280,10 @@ uno::Reference<table::XCellRange> GetRangeByName(
     pUnoCursor->SetMark();
     pUnoCursor->GetPoint()->nNode = *pBRBox->GetSttNd();
     pUnoCursor->Move( fnMoveForward, GoInNode );
-    SwUnoTableCursor* pCursor = dynamic_cast<SwUnoTableCursor*>(pUnoCursor.get());
+    SwUnoTableCursor& rCursor = dynamic_cast<SwUnoTableCursor&>(*pUnoCursor.get());
     // HACK: remove pending actions for selecting old style tables
-    UnoActionRemoveContext aRemoveContext(*pCursor);
-    pCursor->MakeBoxSels();
+    UnoActionRemoveContext aRemoveContext(rCursor);
+    rCursor.MakeBoxSels();
     // pUnoCursor will be provided and will not be deleted
     return SwXCellRange::CreateXCellRange(pUnoCursor, *pFormat, rDesc).get();
 }
commit 1cd862de06a6044f3f9b565ec24c24cd68930a3f
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Aug 5 10:31:00 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Aug 5 20:27:53 2018 +0200

    coverity#1438218 Unchecked dynamic_cast
    
    Change-Id: I59ce652b1a3271fc1f95d76c6a42902db8b1bc68
    Reviewed-on: https://gerrit.libreoffice.org/58607
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sw/source/core/unocore/unotbl.cxx b/sw/source/core/unocore/unotbl.cxx
index 69d51138c319..8da0b3adec3e 100644
--- a/sw/source/core/unocore/unotbl.cxx
+++ b/sw/source/core/unocore/unotbl.cxx
@@ -3358,10 +3358,10 @@ SwXCellRange::getCellRangeByPosition(
                     pUnoCursor->SetMark();
                     pUnoCursor->GetPoint()->nNode = *pBRBox->GetSttNd();
                     pUnoCursor->Move( fnMoveForward, GoInNode );
-                    SwUnoTableCursor* pCursor = dynamic_cast<SwUnoTableCursor*>(pUnoCursor.get());
+                    SwUnoTableCursor& rCursor = dynamic_cast<SwUnoTableCursor&>(*pUnoCursor.get());
                     // HACK: remove pending actions for selecting old style tables
-                    UnoActionRemoveContext aRemoveContext(*pCursor);
-                    pCursor->MakeBoxSels();
+                    UnoActionRemoveContext aRemoveContext(rCursor);
+                    rCursor.MakeBoxSels();
                     // pUnoCursor will be provided and will not be deleted
                     aRet = SwXCellRange::CreateXCellRange(pUnoCursor, *pFormat, aNewDesc).get();
                 }


More information about the Libreoffice-commits mailing list