[Libreoffice-commits] core.git: sfx2/qa
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Thu Aug 9 13:22:42 UTC 2018
sfx2/qa/cppunit/test_misc.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 7cb07a7a7cb2b05be3f698daccf8bfaef427a728
Author: Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Aug 9 13:23:37 2018 +0200
Commit: Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Aug 9 15:22:18 2018 +0200
Improve wording of comment
...as discussed on #libreoffice-dev
Change-Id: I5314bdcaf0e023db615c68785b76f4ee6144b079
Reviewed-on: https://gerrit.libreoffice.org/58758
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
diff --git a/sfx2/qa/cppunit/test_misc.cxx b/sfx2/qa/cppunit/test_misc.cxx
index 88764a63f842..7162dfc58581 100644
--- a/sfx2/qa/cppunit/test_misc.cxx
+++ b/sfx2/qa/cppunit/test_misc.cxx
@@ -140,8 +140,8 @@ void MiscTest::testNoThumbnail()
osl::FileStatus aStatus(osl_FileStatus_Mask_Attributes);
CPPUNIT_ASSERT_EQUAL(osl::DirectoryItem::E_None, aItem.getFileStatus(aStatus));
- // This failed, osl_File_Attribute_GrpRead was not set even if umask
- // requested so.
+ // The following checks used to fail in the past, osl_File_Attribute_GrpRead was not set even if
+ // umask requested so:
CPPUNIT_ASSERT(aStatus.getAttributes() & osl_File_Attribute_GrpRead);
CPPUNIT_ASSERT(aStatus.getAttributes() & osl_File_Attribute_OthRead);
umask(nMask);
More information about the Libreoffice-commits
mailing list