[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - sfx2/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Aug 10 19:38:39 UTC 2018


 sfx2/source/appl/sfxhelp.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit a7485a5db36dc8a8e61285384eed06c46e6a5b53
Author:     Jan Holesovsky <kendy at collabora.com>
AuthorDate: Fri Aug 10 18:54:13 2018 +0200
Commit:     Andras Timar <andras.timar at collabora.com>
CommitDate: Fri Aug 10 21:38:13 2018 +0200

    help: Let's make the help urls more standard, and use ?Target=...&... form.
    
    Change-Id: If9b7f6e50e8e668b7349dae1935ce16965ef19b0
    Reviewed-on: https://gerrit.libreoffice.org/58863
    Reviewed-by: Andras Timar <andras.timar at collabora.com>
    Tested-by: Andras Timar <andras.timar at collabora.com>

diff --git a/sfx2/source/appl/sfxhelp.cxx b/sfx2/source/appl/sfxhelp.cxx
index 694aaf787c97..4d770b0f3ee7 100644
--- a/sfx2/source/appl/sfxhelp.cxx
+++ b/sfx2/source/appl/sfxhelp.cxx
@@ -541,9 +541,9 @@ static bool impl_showOnlineHelp( const OUString& rURL )
 
     OUString aHelpLink( "https://help.libreoffice.org/help.html?"  );
 
-    aHelpLink += rURL.copy( aInternal.getLength() );
-    aHelpLink = aHelpLink.replaceAll("%2F","/");
-
+    OUString aTarget = "Target=" + rURL.copy(aInternal.getLength());
+    aTarget = aTarget.replaceAll("%2F", "/").replaceAll("?", "&");
+    aHelpLink += aTarget;
 
     if (comphelper::LibreOfficeKit::isActive())
     {


More information about the Libreoffice-commits mailing list