[Libreoffice-commits] core.git: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Aug 20 07:23:50 UTC 2018


 sc/source/filter/xml/xmlexprt.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 3e97b8a74b20d72d36ac65d3ef091cae79b8cdac
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Aug 19 23:42:49 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Mon Aug 20 09:23:29 2018 +0200

    coverity#1438402 Improper use of negative value
    
    Change-Id: I00aa17ae4fd543faabc4cb7a052e3561da29c1e6
    Reviewed-on: https://gerrit.libreoffice.org/59311
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx
index c8e83c7c47d8..10ebe9139ca5 100644
--- a/sc/source/filter/xml/xmlexprt.cxx
+++ b/sc/source/filter/xml/xmlexprt.cxx
@@ -1518,6 +1518,7 @@ void ScXMLExport::OpenRow(const sal_Int32 nTable, const sal_Int32 nStartRow, con
             bHidden = rRowAttr.rowHidden(nTable, nStartRow, nEndRowHidden);
             bFiltered = rRowAttr.rowFiltered(nTable, nStartRow, nEndRowFiltered);
         }
+        assert(nIndex >= 0 && "coverity#1438402");
         OpenNewRow(nIndex, nStartRow, 1, bHidden, bFiltered);
     }
     nOpenRow = nStartRow + nRepeatRow - 1;


More information about the Libreoffice-commits mailing list