[Libreoffice-commits] core.git: vcl/qa

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Dec 3 10:15:01 UTC 2018


 vcl/qa/cppunit/pdfexport/pdfexport.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c1feb713f86265c85ad9098d86a86f69110a92c7
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Mon Dec 3 11:12:46 2018 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Mon Dec 3 11:12:46 2018 +0100

    Revert "Check against concrete expected values in PdfExportTest::testTdf115262"
    
    This reverts commit 3bb64c0b26962f3c62dc82353b8ca13479c409be, at least Jenkins'
    lo_tb_master_win builds started to fail with
    
    > C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win/vcl/qa/cppunit/pdfexport/pdfexport.cxx(1581) : error : Assertion
    > Test name: `anonymous namespace'::PdfExportTest::testTdf115262
    > equality assertion failed
    > - Expected: 199
    > - Actual  : 198
    
    (<https://ci.libreoffice.org/job/lo_tb_master_win/19796/>).

diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index 5075fef47a54..001b3de2f480 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -1577,8 +1577,8 @@ void PdfExportTest::testTdf115262()
     }
     // Make sure that the top of the "400" is below the top of the image (in
     // bottom-right-corner-based PDF coordinates).
-    CPPUNIT_ASSERT_EQUAL(232, nFirstImageTop);
-    CPPUNIT_ASSERT_EQUAL(199, nRowTop);
+    // This was: expected less than 144, actual is 199.
+    CPPUNIT_ASSERT_LESS(nFirstImageTop, nRowTop);
     FPDFText_ClosePage(pTextPage);
 }
 


More information about the Libreoffice-commits mailing list