[Libreoffice-commits] core.git: basic/CppunitTest_basic_macros.mk basic/qa

[Libreoffice Gerrit user]

 basic/CppunitTest_basic_macros.mk                         |    2 +
 basic/qa/basic_coverage/test_filedatetime_nonexistent.vb  |   20 ++++++++++++++
 basic/qa/basic_coverage/test_filedatetime_nonexistent2.vb |   20 ++++++++++++++
 3 files changed, 42 insertions(+)

New commits:
commit 834c7c2698443332a347374db10e17d7862d6e4f
Author:     Zdeněk Crhonek <zcrhonek at gmail.com>
AuthorDate: Thu Nov 29 20:49:36 2018 +0100
Commit:     Zdenek Crhonek <zcrhonek at gmail.com>
CommitDate: Mon Dec 3 17:58:38 2018 +0100

    add test for bug tdf#121337
    
    Change-Id: I26d1d426e6a856b09a48efe8e411b8c54e0f35cf
    Reviewed-on: https://gerrit.libreoffice.org/64275
    Tested-by: Jenkins
    Reviewed-by: Zdenek Crhonek <zcrhonek at gmail.com>

diff --git a/basic/CppunitTest_basic_macros.mk b/basic/CppunitTest_basic_macros.mk
index 8b0dccece557..db49876bb652 100644
--- a/basic/CppunitTest_basic_macros.mk
+++ b/basic/CppunitTest_basic_macros.mk
@@ -59,6 +59,8 @@ $(eval $(call gb_CppunitTest_use_vcl,basic_macros))
 $(eval $(call gb_CppunitTest_use_components,basic_macros,\
 	configmgr/source/configmgr \
 	i18npool/util/i18npool \
+	ucb/source/core/ucb1 \
+	ucb/source/ucp/file/ucpfile1 \
 	$(if $(DISABLE_ATL),,$(if $(filter $(OS),WNT), \
 		extensions/source/ole/oleautobridge)) \
 ))
diff --git a/basic/qa/basic_coverage/test_filedatetime_nonexistent.vb b/basic/qa/basic_coverage/test_filedatetime_nonexistent.vb
new file mode 100644
index 000000000000..53a72549c846
--- /dev/null
+++ b/basic/qa/basic_coverage/test_filedatetime_nonexistent.vb
@@ -0,0 +1,20 @@
+' This file is part of the LibreOffice project.
+'
+' This Source Code Form is subject to the terms of the Mozilla Public
+' License, v. 2.0. If a copy of the MPL was not distributed with this
+' file, You can obtain one at http://mozilla.org/MPL/2.0/.
+'
+'Bug 121337 - FileDateTime("\\nonexistent\smb\path") returns bogus result rather than throwing error
+Function doUnitTest as Integer
+    On Error GoTo ErrorHandler ' Set up error handler
+    Dim result
+    result = FileDateTime("/bogus/unix/path")
+    doUnitTest = 0
+    Exit Function
+ErrorHandler:
+    If ( Err <> 0 ) Then
+        doUnitTest = 0
+    Else
+        doUnitTest = 1
+    Endif
+End Function
diff --git a/basic/qa/basic_coverage/test_filedatetime_nonexistent2.vb b/basic/qa/basic_coverage/test_filedatetime_nonexistent2.vb
new file mode 100644
index 000000000000..2135b25d27ec
--- /dev/null
+++ b/basic/qa/basic_coverage/test_filedatetime_nonexistent2.vb
@@ -0,0 +1,20 @@
+' This file is part of the LibreOffice project.
+'
+' This Source Code Form is subject to the terms of the Mozilla Public
+' License, v. 2.0. If a copy of the MPL was not distributed with this
+' file, You can obtain one at http://mozilla.org/MPL/2.0/.
+'
+'Bug 121337 - FileDateTime("\\nonexistent\smb\path") returns bogus result rather than throwing error
+Function doUnitTest as Integer
+    On Error GoTo ErrorHandler ' Set up error handler
+    Dim result
+    result = FileDateTime("\\bogus\smb\path")
+    doUnitTest = 0
+    Exit Function
+ErrorHandler:
+    If ( Err <> 0 ) Then
+        doUnitTest = 0
+    Else
+        doUnitTest = 1
+    Endif
+End Function