[Libreoffice-commits] online.git: test/TileCacheTests.cpp

[Libreoffice Gerrit user]

 test/TileCacheTests.cpp |    6 ------
 1 file changed, 6 deletions(-)

New commits:
commit c04fd49d42dc41ed807cf4a9309a2f503027081e
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Wed Dec 5 09:07:18 2018 +0100
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Wed Dec 5 09:14:50 2018 +0100

    TileCacheTests: these writes are never read
    
    They are written again inside the do { ... } while (...) which runs at
    least once.
    
    Change-Id: I9ff07d7cb68b73bccf1bd38490fcba615b87a6ba

diff --git a/test/TileCacheTests.cpp b/test/TileCacheTests.cpp
index 3f0be4016..3b1954a8b 100644
--- a/test/TileCacheTests.cpp
+++ b/test/TileCacheTests.cpp
@@ -1238,7 +1238,6 @@ void TileCacheTests::testTileWireIDHandling()
 
     // For the second input wsd will send one tile, since some of them are indentical
     arrivedTiles = 0;
-    gotTile = false;
     do
     {
         std::vector<char> tile = getResponseMessage(socket, "tile:", testname);
@@ -1299,7 +1298,6 @@ void TileCacheTests::testTileProcessed()
 
     // Now we can get the remaining tiles
     int arrivedTile2 = 0;
-    gotTile = false;
     do
     {
         std::vector<char> tile = getResponseMessage(socket, "tile:", testname);
@@ -1391,7 +1389,6 @@ void TileCacheTests::testTileBeingRenderedHandling()
         assertResponseString(socket, "invalidatetiles:", testname);
 
         arrivedTiles = 0;
-        gotTile = false;
         do
         {
             std::vector<char> tile = getResponseMessage(socket, "tile:", testname, 500);
@@ -1449,7 +1446,6 @@ void TileCacheTests::testWireIDFilteringOnWSDSide()
 
     // For the second input wsd will send one tile, since other tiles are indentical
     arrivedTiles = 0;
-    gotTile = false;
     do
     {
         std::vector<char> tile = getResponseMessage(socket1, "tile:", testname, 1000);
@@ -1466,7 +1462,6 @@ void TileCacheTests::testWireIDFilteringOnWSDSide()
 
     // We expect three tiles sent to the second client
     arrivedTiles = 0;
-    gotTile = false;
     do
     {
         std::vector<char> tile = getResponseMessage(socket2, "tile:", testname, 1000);
@@ -1511,7 +1506,6 @@ void TileCacheTests::testLimitTileVersionsOnFly()
     sendChar(socket, 'x', skNone, testname);
 
     // Handle all tiles sent by wsd
-    getTileResp = false;
     do
     {
         std::string tile = getResponseString(socket, "tile:", testname, 1000);