[Libreoffice-commits] core.git: sc/inc sc/source

[Libreoffice Gerrit user]

 sc/inc/listenerquery.hxx              |    7 ++-----
 sc/source/core/tool/listenerquery.cxx |   14 ++++----------
 2 files changed, 6 insertions(+), 15 deletions(-)

New commits:
commit 791bb16967a94c2f2afda5383890083738a05a4c
Author:     Takeshi Abe <tabe at fixedpoint.jp>
AuthorDate: Thu Dec 6 21:56:38 2018 +0900
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Dec 7 14:14:07 2018 +0100

    sc: Peel off a pimpl
    
    Change-Id: I8797ccc165fb0a6060c6232babc299114411130a
    Reviewed-on: https://gerrit.libreoffice.org/64707
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sc/inc/listenerquery.hxx b/sc/inc/listenerquery.hxx
index b0f66c73b2d4..a165332c1601 100644
--- a/sc/inc/listenerquery.hxx
+++ b/sc/inc/listenerquery.hxx
@@ -11,13 +11,11 @@
 #define SC_LISTENERQUERY_HXX
 
 #include "address.hxx"
+#include "rangelst.hxx"
 #include <svl/listener.hxx>
 
 #include <unordered_map>
 #include <vector>
-#include <memory>
-
-class ScRangeList;
 
 namespace sc {
 
@@ -51,8 +49,7 @@ private:
 
 class QueryRange : public SvtListener::QueryBase
 {
-    struct Impl;
-    std::unique_ptr<Impl> mpImpl;
+    ScRangeList maRanges;
 
     QueryRange( const QueryRange& ) = delete;
     QueryRange& operator= ( const QueryRange& ) = delete;
diff --git a/sc/source/core/tool/listenerquery.cxx b/sc/source/core/tool/listenerquery.cxx
index a36957e1c943..ce2fe9faa5d6 100644
--- a/sc/source/core/tool/listenerquery.cxx
+++ b/sc/source/core/tool/listenerquery.cxx
@@ -10,7 +10,6 @@
 #include <listenerquery.hxx>
 #include <listenerqueryids.hxx>
 #include <address.hxx>
-#include <rangelst.hxx>
 
 namespace sc {
 
@@ -68,14 +67,9 @@ const RefQueryFormulaGroup::TabsType& RefQueryFormulaGroup::getAllPositions() co
     return maTabs;
 }
 
-struct QueryRange::Impl
-{
-    ScRangeList maRanges;
-};
-
 QueryRange::QueryRange() :
-    SvtListener::QueryBase(SC_LISTENER_QUERY_FORMULA_GROUP_RANGE),
-    mpImpl(new Impl) {}
+    SvtListener::QueryBase(SC_LISTENER_QUERY_FORMULA_GROUP_RANGE)
+{}
 
 QueryRange::~QueryRange()
 {
@@ -83,12 +77,12 @@ QueryRange::~QueryRange()
 
 void QueryRange::add( const ScRange& rRange )
 {
-    mpImpl->maRanges.Join(rRange);
+    maRanges.Join(rRange);
 }
 
 void QueryRange::swapRanges( ScRangeList& rRanges )
 {
-    mpImpl->maRanges.swap(rRanges);
+    maRanges.swap(rRanges);
 }
 
 }