[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/unx
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Sun Dec 9 21:13:14 UTC 2018
vcl/unx/gtk3/gtk3gtkinst.cxx | 2 ++
1 file changed, 2 insertions(+)
New commits:
commit 03f724a1ba9155a100f51954871f22f858859299
Author: Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Sat Dec 8 20:41:53 2018 +0200
Commit: Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Dec 9 22:12:54 2018 +0100
missing g_signal_handler_disconnect in GtkInstanceWidget
found by loplugin:unusedfields
Change-Id: Iefd64e879b32f696456c51da595e462295e5c58e
Reviewed-on: https://gerrit.libreoffice.org/64820
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
(cherry picked from commit 145280ffd1dabdc629c14c8162beef668741bcef)
Reviewed-on: https://gerrit.libreoffice.org/64847
Reviewed-by: Caolán McNamara <caolanm at redhat.com>
Tested-by: Caolán McNamara <caolanm at redhat.com>
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index ebf175b3e0eb..028462532918 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -1606,6 +1606,8 @@ public:
{
if (m_nKeyPressSignalId)
g_signal_handler_disconnect(m_pWidget, m_nKeyPressSignalId);
+ if (m_nKeyReleaseSignalId)
+ g_signal_handler_disconnect(m_pWidget, m_nKeyReleaseSignalId);
if (m_nFocusInSignalId)
g_signal_handler_disconnect(m_pWidget, m_nFocusInSignalId);
if (m_nFocusOutSignalId)
More information about the Libreoffice-commits
mailing list