[Libreoffice-commits] core.git: connectivity/qa

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Dec 10 09:41:22 UTC 2018


 connectivity/qa/complex/connectivity/JdbcLongVarCharTest.java |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit c56b2e3f8dc260e9927289ca382534f491b97aba
Author:     Rene Engelhard <rene at debian.org>
AuthorDate: Sun Dec 9 22:56:16 2018 +0100
Commit:     Lionel Elie Mamane <lionel at mamane.lu>
CommitDate: Mon Dec 10 10:41:01 2018 +0100

    replace hardcoded jdbc mysql driver URL with env variable
    
    introduce CONNECTIVITY_TEST_MYSQL_DRIVER_JDBC analogous to
    CONNECTIVITY_TEST_MYSQL_DRIVER for mysqlc
    
    Change-Id: I90b14e7145418248de79aa9d4bf4285fd4f98f9d
    Reviewed-on: https://gerrit.libreoffice.org/64854
    Tested-by: Jenkins
    Reviewed-by: Lionel Elie Mamane <lionel at mamane.lu>

diff --git a/connectivity/qa/complex/connectivity/JdbcLongVarCharTest.java b/connectivity/qa/complex/connectivity/JdbcLongVarCharTest.java
index a44f1b9d1241..73f6ca2d5116 100644
--- a/connectivity/qa/complex/connectivity/JdbcLongVarCharTest.java
+++ b/connectivity/qa/complex/connectivity/JdbcLongVarCharTest.java
@@ -57,7 +57,12 @@ public class JdbcLongVarCharTest extends ComplexTestCase
         {
             System.out.println("== Start testing ==");
 
-            String url = "jdbc:mysql://localhost:3306/mysql?user=root";
+            /* Get URL from environment variable.
+            *
+            * Example URL:
+            * jdbc:mysql://localhost:3306/mysql?user=username?password=password
+            */
+            String url = System.getenv("CONNECTIVITY_TEST_MYSQL_DRIVER_JDBC");
             com.sun.star.beans.PropertyValue prop[] = new PropertyValue[1];
             prop[0] = new PropertyValue("JavaDriverClass", 0, "com.mysql.jdbc.Driver", PropertyState.DIRECT_VALUE);
 


More information about the Libreoffice-commits mailing list