[Libreoffice-commits] core.git: vcl/unx

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Dec 13 14:11:01 UTC 2018


 vcl/unx/gtk/gtksalmenu.cxx |    5 +++++
 1 file changed, 5 insertions(+)

New commits:
commit a32059cfd1fa12eeb93b1ed3079ded0ce42deef6
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Dec 13 11:50:41 2018 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Dec 13 15:10:36 2018 +0100

    Resolves: tdf#122016 crash accessing deleted GtkSalMenu
    
    Change-Id: Ib6527e17110b55251fea9f0701d0e02f6fa5a9fe
    Reviewed-on: https://gerrit.libreoffice.org/65092
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk/gtksalmenu.cxx b/vcl/unx/gtk/gtksalmenu.cxx
index e504e5d7aef0..f9053ce23f6f 100644
--- a/vcl/unx/gtk/gtksalmenu.cxx
+++ b/vcl/unx/gtk/gtksalmenu.cxx
@@ -506,6 +506,8 @@ bool GtkSalMenu::ShowNativePopupMenu(FloatingWindow* pWin, const tools::Rectangl
     g_object_unref(mpActionGroup);
     ClearActionGroupAndMenuModel();
 
+    mpFrame = nullptr;
+
     return true;
 #else
     (void)pWin;
@@ -581,6 +583,9 @@ GtkSalMenu::~GtkSalMenu()
         g_object_unref(mpMenuModel);
 
     maItems.clear();
+
+    if (mpFrame)
+        mpFrame->SetMenu(nullptr);
 }
 
 bool GtkSalMenu::VisibleMenuBar()


More information about the Libreoffice-commits mailing list