[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - vcl/qt5

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed Dec 19 12:14:21 UTC 2018


 vcl/qt5/Qt5FilePicker.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 77c5d0f4be46071f49957e3e2f7fce24f9e927f3
Author:     Aleksei Nikiforov <darktemplar at basealt.ru>
AuthorDate: Tue Dec 18 16:39:57 2018 +0300
Commit:     Katarina Behrens <Katarina.Behrens at cib.de>
CommitDate: Wed Dec 19 13:13:59 2018 +0100

    Qt5: remove assert leading to crash while executing 'open' dialog
    
    When Writer is opened using "qt5" VCL plugin,
    opening menu item "File" -> "Open" leads to a crash
    due to presence of mentioned assert.
    
    Impress crashes same way when same menu item is used.
    
    Change-Id: I9d1937344c694d4f4620be1b71d1181eb9645427
    Reviewed-on: https://gerrit.libreoffice.org/65344
    Tested-by: Jenkins
    Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>
    (cherry picked from commit dd2421b148fedc40547ccff8b332285047a0b09e)
    Reviewed-on: https://gerrit.libreoffice.org/65396
    Reviewed-by: Aleksei Nikiforov <darktemplar at basealt.ru>
    Reviewed-by: Katarina Behrens <Katarina.Behrens at cib.de>

diff --git a/vcl/qt5/Qt5FilePicker.cxx b/vcl/qt5/Qt5FilePicker.cxx
index 2895bc34bc1c..ffd482ded5d0 100644
--- a/vcl/qt5/Qt5FilePicker.cxx
+++ b/vcl/qt5/Qt5FilePicker.cxx
@@ -187,7 +187,6 @@ sal_Int16 SAL_CALL Qt5FilePicker::execute()
     }
 
     vcl::Window* pWindow = ::Application::GetActiveTopWindow();
-    assert(pWindow);
     QWidget* pTransientParent = nullptr;
     QWindow* pTransientWindow = nullptr;
     if (pWindow)


More information about the Libreoffice-commits mailing list