[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - dbaccess/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Dec 21 16:06:50 UTC 2018


 dbaccess/source/filter/hsqldb/hsqlimport.cxx |   12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

New commits:
commit 2c0c0794a8e287497e460f3f1e6bcba585d675d4
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Dec 21 13:42:24 2018 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Dec 21 17:06:26 2018 +0100

    Resolves: tdf#121838 catch exception for missing column
    
    in database migration
    
    Change-Id: Ied42d1436f14012fb918e8e6775fcbe0f7d5fac5
    Reviewed-on: https://gerrit.libreoffice.org/65546
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/dbaccess/source/filter/hsqldb/hsqlimport.cxx b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
index 49d6f978e6b6..b29889c1b6cd 100644
--- a/dbaccess/source/filter/hsqldb/hsqlimport.cxx
+++ b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
@@ -338,11 +338,21 @@ void HsqlImporter::importHsqlDatabase(weld::Window* pParent)
     // data
     for (const auto& tableIndex : parser.getTableIndexes())
     {
-        std::vector<ColumnDefinition> aColTypes = parser.getTableColumnTypes(tableIndex.first);
         try
         {
+            std::vector<ColumnDefinition> aColTypes = parser.getTableColumnTypes(tableIndex.first);
             parseTableRows(tableIndex.second, aColTypes, tableIndex.first);
         }
+        catch (const std::out_of_range& e)
+        {
+            std::unique_ptr<SQLException> ex(new SQLException);
+            const char* msg = e.what();
+            ex->SQLState = OUString(msg, strlen(msg), RTL_TEXTENCODING_ASCII_US);
+            // chain errors and keep going
+            if (pException)
+                ex->NextException <<= *pException;
+            pException = std::move(ex);
+        }
         catch (SQLException& ex)
         {
             // chain errors and keep going


More information about the Libreoffice-commits mailing list