[Libreoffice-commits] core.git: filter/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sun Dec 23 17:11:17 UTC 2018


 filter/source/msfilter/msdffimp.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 41a36dc2bfc6a60baf3d93ffe16ccb3430cd87ae
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Dec 23 15:24:22 2018 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Dec 23 18:10:54 2018 +0100

    tdf#122204 reversed checked_multiply check
    
    since...
    
    Author: Caolán McNamara <caolanm at redhat.com>
    Date:   Wed Oct 24 14:06:03 2018 +0100
    
        ofz#11103 Integer-overflow
    
    Change-Id: Id32a5c14cfce2d7f22ca319c104908c441c3abc5
    Reviewed-on: https://gerrit.libreoffice.org/65580
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx
index 0178c1af94ef..8f79471e7351 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -4565,7 +4565,7 @@ SdrObject* SvxMSDffManager::ImportShape( const DffRecordHeader& rHd, SvStream& r
                                 seqAdjustmentValues[ 0 ].Value >>= fNumber;
                                 sal_Int32 nValue;
                                 bool bFail = o3tl::checked_multiply<sal_Int32>(fNumber, 100, nValue);
-                                if (!bFail)
+                                if (bFail)
                                     SAL_WARN("filter.ms", "nEndAngle too large: " << fNumber);
                                 else
                                     nEndAngle = NormAngle36000(-nValue);


More information about the Libreoffice-commits mailing list