[Libreoffice-commits] core.git: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed Dec 26 20:43:30 UTC 2018


 sc/source/filter/excel/excrecds.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d080cd838c7ab182e70ed5e8c1deff10b2306f24
Author:     Noel Grandin <noelgrandin at gmail.com>
AuthorDate: Wed Dec 26 20:57:31 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Wed Dec 26 21:43:06 2018 +0100

    tdf#122331 Autofilter disappeared after export to XLSX
    
    regression from
        commit c135f51b050dfa7ef095fe8a5b73cde37219a8dd
        loplugin:returnconstant in XclExpAutofilter
    
    Change-Id: Iea7ac925aff47699292b4c3d758e99cd2d081560
    Reviewed-on: https://gerrit.libreoffice.org/65625
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sc/source/filter/excel/excrecds.cxx b/sc/source/filter/excel/excrecds.cxx
index 093cfeb254e3..1ddf17d08f85 100644
--- a/sc/source/filter/excel/excrecds.cxx
+++ b/sc/source/filter/excel/excrecds.cxx
@@ -666,7 +666,7 @@ bool XclExpAutofilter::AddEntry( const ScQueryEntry& rEntry )
     if (GetOutput() != EXC_OUTPUT_BINARY && rItems.size() > 1)
     {
         AddMultiValueEntry(rEntry);
-        return true;
+        return false;
     }
 
     bool bConflict = false;


More information about the Libreoffice-commits mailing list