[Libreoffice-commits] core.git: vcl/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Dec 27 11:05:32 UTC 2018


 vcl/source/outdev/bitmap.cxx |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit a7ff057c2bc1d8e034e190c1d06846f26083630b
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Thu Dec 27 13:02:46 2018 +0200
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Thu Dec 27 13:04:33 2018 +0200

    Add some pondering what a comment means...
    
    Change-Id: I8835a5910df8c8cd2f17c4b6a46549575ea22d8c

diff --git a/vcl/source/outdev/bitmap.cxx b/vcl/source/outdev/bitmap.cxx
index 4ad7d40b397a..16f4b576ab15 100644
--- a/vcl/source/outdev/bitmap.cxx
+++ b/vcl/source/outdev/bitmap.cxx
@@ -1,4 +1,4 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
 /*
  * This file is part of the LibreOffice project.
  *
@@ -643,6 +643,12 @@ void OutputDevice::DrawDeviceAlphaBitmap( const Bitmap& rBmp, const AlphaMask& r
         static const char* pDisableNative = getenv( "SAL_DISABLE_NATIVE_ALPHA");
         // #i83087# Naturally, system alpha blending cannot work with
         // separate alpha VDev
+
+        // Not clear how the above comment relates to the following declaration and initialisation
+        // of bTryDirectPaint. Does bTryDirectPaint being true mean that we can use "system alpha
+        // blending"? Or that we can't? Or are the two not related at all, and should the above
+        // comment actually be better located below, before the "if (mpAlphaVDev)" test?
+
         bool bTryDirectPaint(!pDisableNative && !bHMirr && !bVMirr);
 
         if (bTryDirectPaint)


More information about the Libreoffice-commits mailing list