[Libreoffice-commits] core.git: basctl/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Dec 28 15:44:31 UTC 2018


 basctl/source/basicide/macrodlg.cxx |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit d94e6be598ecd42807aa2e64cb2e613eb77f90a9
Author:     Matteo Casalin <matteo.casalin at yahoo.com>
AuthorDate: Fri Nov 23 22:04:41 2018 +0100
Commit:     Matteo Casalin <matteo.casalin at yahoo.com>
CommitDate: Fri Dec 28 16:44:09 2018 +0100

    Do not use indexing for single getToken call
    
    Change-Id: Id1d7385f927e0ef08f9a0a170420feccdcd75ed2
    Reviewed-on: https://gerrit.libreoffice.org/65660
    Tested-by: Jenkins
    Reviewed-by: Matteo Casalin <matteo.casalin at yahoo.com>

diff --git a/basctl/source/basicide/macrodlg.cxx b/basctl/source/basicide/macrodlg.cxx
index cd314bcb4ccd..f882d7a9542f 100644
--- a/basctl/source/basicide/macrodlg.cxx
+++ b/basctl/source/basicide/macrodlg.cxx
@@ -319,8 +319,7 @@ SbMethod* MacroChooser::CreateMacro()
             // extract the module name from the string like "Sheet1 (Example1)"
             if( aDesc.GetLibSubName() == IDEResId(RID_STR_DOCUMENT_OBJECTS) )
             {
-                sal_Int32 nIndex = 0;
-                aModName = aModName.getToken( 0, ' ', nIndex );
+                aModName = aModName.getToken( 0, ' ' );
             }
             pModule = pBasic->FindModule( aModName );
         }
@@ -627,8 +626,7 @@ IMPL_LINK(MacroChooser, ButtonHdl, weld::Button&, rButton, void)
         // extract the module name from the string like "Sheet1 (Example1)"
         if( aDesc.GetLibSubName() == IDEResId(RID_STR_DOCUMENT_OBJECTS) )
         {
-            sal_Int32 nIndex = 0;
-            aMod = aMod.getToken( 0, ' ', nIndex );
+            aMod = aMod.getToken( 0, ' ' );
         }
         const OUString& aSub( aDesc.GetMethodName() );
         SfxMacroInfoItem aInfoItem( SID_BASICIDE_ARG_MACROINFO, pBasMgr, aLib, aMod, aSub, OUString() );


More information about the Libreoffice-commits mailing list