[Libreoffice-commits] core.git: chart2/qa

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Dec 28 15:49:47 UTC 2018


 chart2/qa/extras/chart2dump/chart2dump.cxx |   19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

New commits:
commit c877e2e22bd045f3f6b05bf185b30ed32e7f0b39
Author:     Matteo Casalin <matteo.casalin at yahoo.com>
AuthorDate: Tue Nov 27 23:10:05 2018 +0100
Commit:     Matteo Casalin <matteo.casalin at yahoo.com>
CommitDate: Fri Dec 28 16:49:27 2018 +0100

    Use indexed getToken
    
    Change-Id: Ia44cbd763d06948fcf7f7633d0ee0b1aaeeda84a
    Reviewed-on: https://gerrit.libreoffice.org/65664
    Tested-by: Jenkins
    Reviewed-by: Matteo Casalin <matteo.casalin at yahoo.com>

diff --git a/chart2/qa/extras/chart2dump/chart2dump.cxx b/chart2/qa/extras/chart2dump/chart2dump.cxx
index e06ce2f76415..001382bbfe39 100644
--- a/chart2/qa/extras/chart2dump/chart2dump.cxx
+++ b/chart2/qa/extras/chart2dump/chart2dump.cxx
@@ -203,15 +203,16 @@ protected:
 
         // Convert string back to a transformation;
         drawing::HomogenMatrix3 aExpectedTransform;
-        aExpectedTransform.Line1.Column1 = rExpectedTranform.getToken(0, ';').toDouble();
-        aExpectedTransform.Line1.Column2 = rExpectedTranform.getToken(1, ';').toDouble();
-        aExpectedTransform.Line1.Column3 = rExpectedTranform.getToken(2, ';').toDouble();
-        aExpectedTransform.Line2.Column1 = rExpectedTranform.getToken(3, ';').toDouble();
-        aExpectedTransform.Line2.Column2 = rExpectedTranform.getToken(4, ';').toDouble();
-        aExpectedTransform.Line2.Column3 = rExpectedTranform.getToken(5, ';').toDouble();
-        aExpectedTransform.Line3.Column1 = rExpectedTranform.getToken(6, ';').toDouble();
-        aExpectedTransform.Line3.Column2 = rExpectedTranform.getToken(7, ';').toDouble();
-        aExpectedTransform.Line3.Column3 = rExpectedTranform.getToken(8, ';').toDouble();
+        sal_Int32 nIdx {0};
+        aExpectedTransform.Line1.Column1 = rExpectedTranform.getToken(0, ';', nIdx).toDouble();
+        aExpectedTransform.Line1.Column2 = rExpectedTranform.getToken(0, ';', nIdx).toDouble();
+        aExpectedTransform.Line1.Column3 = rExpectedTranform.getToken(0, ';', nIdx).toDouble();
+        aExpectedTransform.Line2.Column1 = rExpectedTranform.getToken(0, ';', nIdx).toDouble();
+        aExpectedTransform.Line2.Column2 = rExpectedTranform.getToken(0, ';', nIdx).toDouble();
+        aExpectedTransform.Line2.Column3 = rExpectedTranform.getToken(0, ';', nIdx).toDouble();
+        aExpectedTransform.Line3.Column1 = rExpectedTranform.getToken(0, ';', nIdx).toDouble();
+        aExpectedTransform.Line3.Column2 = rExpectedTranform.getToken(0, ';', nIdx).toDouble();
+        aExpectedTransform.Line3.Column3 = rExpectedTranform.getToken(0, ';', nIdx).toDouble();
 
         // Check the equality of the two transformation
         return (std::abs(aExpectedTransform.Line1.Column1 - rTransform.Line1.Column1) < fEPS &&


More information about the Libreoffice-commits mailing list