[Libreoffice-commits] core.git: chart2/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Dec 28 23:14:34 UTC 2018


 chart2/source/tools/ObjectIdentifier.cxx |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 3bfe10125888bcbd9f35daa4724b6fe913f4414b
Author:     Matteo Casalin <matteo.casalin at yahoo.com>
AuthorDate: Tue Nov 27 23:46:11 2018 +0100
Commit:     Matteo Casalin <matteo.casalin at yahoo.com>
CommitDate: Sat Dec 29 00:14:07 2018 +0100

    Do not use indexing for single getToken call, simplify
    
    Change-Id: I8ee0ccbbc596a4edd0da50e8bbcf573afc9bb53b
    Reviewed-on: https://gerrit.libreoffice.org/65665
    Tested-by: Jenkins
    Reviewed-by: Matteo Casalin <matteo.casalin at yahoo.com>

diff --git a/chart2/source/tools/ObjectIdentifier.cxx b/chart2/source/tools/ObjectIdentifier.cxx
index a884afea02df..3b358ddc946e 100644
--- a/chart2/source/tools/ObjectIdentifier.cxx
+++ b/chart2/source/tools/ObjectIdentifier.cxx
@@ -1120,11 +1120,8 @@ OUString ObjectIdentifier::createChildParticleWithIndex( ObjectType eObjectType,
 
 sal_Int32 ObjectIdentifier::getIndexFromParticleOrCID( const OUString& rParticleOrCID )
 {
-    OUString aIndexString = lcl_getIndexStringAfterString( rParticleOrCID, "=" );
-    sal_Int32 nCharacterIndex=0;
-    sal_Int32 nRet = lcl_StringToIndex( aIndexString.getToken( 0, ',', nCharacterIndex ) );
-
-    return nRet;
+    const OUString aIndexString = lcl_getIndexStringAfterString( rParticleOrCID, "=" );
+    return lcl_StringToIndex( aIndexString.getToken( 0, ',' ) );
 }
 
 OUString ObjectIdentifier::createSeriesSubObjectStub( ObjectType eSubObjectType


More information about the Libreoffice-commits mailing list