[Libreoffice-commits] core.git: basctl/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sun Dec 30 13:44:05 UTC 2018


 basctl/source/basicide/bastypes.cxx |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 6f967e3403c6675bbaf2c17dcadf7e640dd719ca
Author:     Çağrı Dolaz <cadveri1 at gmail.com>
AuthorDate: Sun Dec 30 13:35:48 2018 +0200
Commit:     Muhammet Kara <muhammet.kara at collabora.com>
CommitDate: Sun Dec 30 14:43:43 2018 +0100

    tdf#112689: Replace chained O(U)StringBuffer::append() with operator+
    
    Change-Id: I0ccf939f44c4f9570a9987d06369294927c765d2
    Reviewed-on: https://gerrit.libreoffice.org/65739
    Tested-by: Jenkins
    Reviewed-by: Muhammet Kara <muhammet.kara at collabora.com>

diff --git a/basctl/source/basicide/bastypes.cxx b/basctl/source/basicide/bastypes.cxx
index 6aef236e50a3..5ffbfbfd302d 100644
--- a/basctl/source/basicide/bastypes.cxx
+++ b/basctl/source/basicide/bastypes.cxx
@@ -710,10 +710,8 @@ LibInfo::Item::~Item ()
 
 static bool QueryDel(const OUString& rName, const OUString &rStr, weld::Widget* pParent)
 {
-    OUStringBuffer aNameBuf( rName );
-    aNameBuf.append('\'');
-    aNameBuf.insert(0, '\'');
-    OUString aQuery = rStr.replaceAll("XX", aNameBuf.makeStringAndClear());
+    OUString aName = "\'" + rName + "\'";
+    OUString aQuery = rStr.replaceAll("XX", aName);
     std::unique_ptr<weld::MessageDialog> xQueryBox(Application::CreateMessageDialog(pParent,
                                                    VclMessageType::Question, VclButtonsType::YesNo, aQuery));
     return (xQueryBox->run() == RET_YES);


More information about the Libreoffice-commits mailing list