[Libreoffice-commits] core.git: compilerplugins/clang lotuswordpro/inc lotuswordpro/source

[Noel Grandin]

 compilerplugins/clang/datamembershadow.cxx         |    2 --
 lotuswordpro/inc/xfilter/xfcellstyle.hxx           |    1 -
 lotuswordpro/source/filter/xfilter/xfparastyle.cxx |    2 --
 3 files changed, 5 deletions(-)

New commits:
commit 0913b2af7d2443099626f65f6105fc67e5fccb56
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Wed Jan 31 16:13:48 2018 +0200

    loplugin:datamembershadow in XFCellStyle
    
    looks like the subclass member is never written to, so I'm going to
    assume this was a bug
    
    Change-Id: Ic56c4a30cd139415eb08c4d572273dad2411b514
    Reviewed-on: https://gerrit.libreoffice.org/49001
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/datamembershadow.cxx b/compilerplugins/clang/datamembershadow.cxx
index 5843085b43c0..210ee1c9a0d1 100644
--- a/compilerplugins/clang/datamembershadow.cxx
+++ b/compilerplugins/clang/datamembershadow.cxx
@@ -63,8 +63,6 @@ bool DataMemberShadow::VisitFieldDecl(FieldDecl const * fieldDecl)
         return true;
     if (loplugin::isSamePathname(aFileName, SRCDIR "/framework/source/uielement/popuptoolbarcontroller.cxx"))
         return true;
-    if (loplugin::isSamePathname(aFileName, SRCDIR "/lotuswordpro/inc/xfilter/xfcellstyle.hxx"))
-        return true;
     if (loplugin::isSamePathname(aFileName, SRCDIR "/sc/source/ui/vba/vbastyles.hxx"))
         return true;
     if (loplugin::isSamePathname(aFileName, SRCDIR "/sd/inc/Outliner.hxx"))
diff --git a/lotuswordpro/inc/xfilter/xfcellstyle.hxx b/lotuswordpro/inc/xfilter/xfcellstyle.hxx
index ee3a2c6a8b4a..6dc5724e7784 100644
--- a/lotuswordpro/inc/xfilter/xfcellstyle.hxx
+++ b/lotuswordpro/inc/xfilter/xfcellstyle.hxx
@@ -134,7 +134,6 @@ public:
 
 private:
     OUString   m_strDataStyle;
-    OUString   m_strParentStyleName;
     enumXFAlignType m_eHoriAlign;
     enumXFAlignType m_eVertAlign;
 
diff --git a/lotuswordpro/source/filter/xfilter/xfparastyle.cxx b/lotuswordpro/source/filter/xfilter/xfparastyle.cxx
index 04de9138e488..97ac01022f80 100644
--- a/lotuswordpro/source/filter/xfilter/xfparastyle.cxx
+++ b/lotuswordpro/source/filter/xfilter/xfparastyle.cxx
@@ -103,8 +103,6 @@ XFParaStyle::XFParaStyle(const XFParaStyle& other)
     , m_nFlag(other.m_nFlag)
     , m_bNumberRight(other.m_bNumberRight)
 {
-    m_strParentStyleName = other.m_strParentStyleName;
-
     if( other.m_pBorders )
         m_pBorders = new XFBorders(*other.m_pBorders);
     else