[Libreoffice-commits] core.git: compilerplugins/clang

[Noel Grandin]

 compilerplugins/clang/refcounting.cxx        |    7 -------
 compilerplugins/clang/unnecessaryvirtual.cxx |    1 -
 2 files changed, 8 deletions(-)

New commits:
commit 62222b40973fa71eba6c77bdd85be30864350f3f
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Wed Jan 31 17:26:29 2018 +0200

    these TODOs have been done
    
    Change-Id: I5457f38f4668175a8f3e1b0f24a90963ee9d585f
    Reviewed-on: https://gerrit.libreoffice.org/49076
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/refcounting.cxx b/compilerplugins/clang/refcounting.cxx
index 091ed20a0d12..8133e281d8aa 100644
--- a/compilerplugins/clang/refcounting.cxx
+++ b/compilerplugins/clang/refcounting.cxx
@@ -33,8 +33,6 @@ If you see another class:
 this is a bug =) since aFooMember assumes heap allocated lifecycle and
 not delete on last 'release'.
 
-TODO check that things that extend SvRefBase are managed by SvRef
-TODO fix the slideshow::internal::SlideView class (mentioned below)
 */
 
 namespace {
@@ -133,11 +131,6 @@ bool containsXInterfaceSubclass(const clang::Type* pType0) {
         if (isDerivedFrom(pRecordDecl, [](Decl const * decl) -> bool { return bool(loplugin::DeclCheck(decl).Class("OSbaWeakSubObject").Namespace("dbaui").GlobalNamespace()); })) { // module dbaccess
             return false;
         }
-        // The actual problem child is SlideView, of which this is the parent.
-        // Everything in the hierarchy above this wants to be managed via boost::shared_ptr
-        if (isDerivedFrom(pRecordDecl, [](Decl const * decl) -> bool { return bool(loplugin::DeclCheck(decl).Class("UnoView").Namespace("internal").Namespace("slideshow").GlobalNamespace()); })) { // module slideshow
-            return false;
-        }
         // FIXME This class has private operator new, and I cannot figure out how it can be dynamically instantiated
         if (isDerivedFrom(pRecordDecl, [](Decl const * decl) -> bool { return bool(loplugin::DeclCheck(decl).Class("XPropertyList").GlobalNamespace()); })) { // module svx
             return false;
diff --git a/compilerplugins/clang/unnecessaryvirtual.cxx b/compilerplugins/clang/unnecessaryvirtual.cxx
index f9283e3a1754..277ef8f5bf02 100644
--- a/compilerplugins/clang/unnecessaryvirtual.cxx
+++ b/compilerplugins/clang/unnecessaryvirtual.cxx
@@ -29,7 +29,6 @@ Note that the actual process may involve a fair amount of undoing, hand editing,
 to get it to work :-)
 
 TODO some boost bind stuff appears to confuse it, notably in the xmloff module
-TODO does not find destructors that don't need to be virtual
 */
 
 namespace {