[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - common/Util.cpp

Miklos Vajna vmiklos at collabora.co.uk
Mon Feb 5 14:30:32 UTC 2018


 common/Util.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 53384000a26222b5ba7189df43fa40022e53e153
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Tue Jan 30 15:50:10 2018 +0100

    common: avoid pointless copy in Util
    
    loolforkit is never able to get the arguments passed to it without this
    patch and nothing starts.
    
    Change-Id: I40097203eba6fede78a17caf057452f4704b2bd4
    (cherry picked from commit 222399e99a2cec31bf6414252765098467629f70)
    Reviewed-on: https://gerrit.libreoffice.org/49243
    Reviewed-by: pranavk <pranavk at collabora.co.uk>
    Tested-by: pranavk <pranavk at collabora.co.uk>

diff --git a/common/Util.cpp b/common/Util.cpp
index 357f6da8..8c7792c9 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -173,7 +173,7 @@ namespace Util
 
         std::vector<char *> params;
         params.push_back(const_cast<char *>(cmd.c_str()));
-        for (auto i : args)
+        for (const auto& i : args)
             params.push_back(const_cast<char *>(i.c_str()));
         params.push_back(nullptr);
 


More information about the Libreoffice-commits mailing list