[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sc/source

Eike Rathke erack at redhat.com
Tue Feb 6 09:25:38 UTC 2018


 sc/source/core/data/documen8.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 71adbb0aa8a945665aab2a0a29c7a09e5d894ad4
Author: Eike Rathke <erack at redhat.com>
Date:   Mon Feb 5 23:13:08 2018 +0100

    Turn assert into SAL_WARN
    
    In the wild there are named expressions without expression and
    formula error cells without formula.
    
    Change-Id: I11546b09173de65cebe776529edee74c549d73c8
    (cherry picked from commit 951dd781743c975a7d29cc30e88e1b4a56c0b176)
    Reviewed-on: https://gerrit.libreoffice.org/49258
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx
index f38a3c63b457..ee30432eafca 100644
--- a/sc/source/core/data/documen8.cxx
+++ b/sc/source/core/data/documen8.cxx
@@ -1194,7 +1194,10 @@ void ScDocument::CheckLinkFormulaNeedingCheck( const ScTokenArray& rCode )
     }
     else
     {
-        assert(!"called with empty ScTokenArray");
+        // Possible with named expression without expression like Excel
+        // internal print ranges, obscure user define names, ... formula error
+        // cells without formula ...
+        SAL_WARN("sc.core","ScDocument::CheckLinkFormulaNeedingCheck - called with empty ScTokenArray");
     }
 }
 


More information about the Libreoffice-commits mailing list