[Libreoffice-commits] core.git: xmloff/source

Caolán McNamara caolanm at redhat.com
Sat Feb 10 16:56:35 UTC 2018


 xmloff/source/core/unointerfacetouniqueidentifiermapper.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit fc763bd9b96eb99c40734bd3db332c2d4bd84d06
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Feb 10 16:55:30 2018 +0000

    ofz#6180 Integer-overflow
    
    Change-Id: Ibf4b40521f5be3866451e574abc59b7e1cf3aec9

diff --git a/xmloff/source/core/unointerfacetouniqueidentifiermapper.cxx b/xmloff/source/core/unointerfacetouniqueidentifiermapper.cxx
index 5e144d7f7053..00a97a9cc3fa 100644
--- a/xmloff/source/core/unointerfacetouniqueidentifiermapper.cxx
+++ b/xmloff/source/core/unointerfacetouniqueidentifiermapper.cxx
@@ -167,7 +167,10 @@ void UnoInterfaceToUniqueIdentifierMapper::insertReference( const OUString& rIde
     // an integer value like this one
     sal_Int32 nId = rIdentifier.copy(2).toInt32();
     if (nId > 0 && mnNextId <= static_cast<sal_uInt32>(nId))
-        mnNextId = nId + 1;
+    {
+        mnNextId = nId;
+        ++mnNextId;
+    }
 }
 
 }


More information about the Libreoffice-commits mailing list