[Libreoffice-commits] core.git: oox/source

Bartosz Kosiorek bartosz.kosiorek at tomtom.com
Sat Feb 17 18:53:32 UTC 2018


 oox/source/export/chartexport.cxx |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 5b9e76557d2b5c835a5873de1ce530f36ea98d2d
Author: Bartosz Kosiorek <bartosz.kosiorek at tomtom.com>
Date:   Thu Feb 8 14:15:48 2018 +0100

    tdf#114139 Don't export Plot Area shape property fot 3D charts
    
    For 2D charts Plot Area equivalent is Chart Wall.
    Unfortunately LibreOffice doesn't have Plot Area equivalent for 3D chart.
    It means that Plot Area couldn't be displayed and changed for 3D chars in LibreOffice.
    We cannot write Wall attributes into Plot Area for 3D charts, because Wall us used as background wall.
    
    Change-Id: I16d3b326571c1e411a094ec799e20c7aeeb2c1d4
    Reviewed-on: https://gerrit.libreoffice.org/49428
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx
index 8e1a05be1ae0..cb4994aa89be 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -1156,7 +1156,11 @@ void ChartExport::exportPlotArea( const Reference< css::chart::XChartDocument >&
      * eg: Fill and Outline
      */
     Reference< css::chart::X3DDisplay > xWallFloorSupplier( mxDiagram, uno::UNO_QUERY );
-    if( xWallFloorSupplier.is() )
+    // tdf#114139 For 2D charts Plot Area equivalent is Chart Wall.
+    // Unfortunately LibreOffice doesn't have Plot Area equivalent for 3D charts.
+    // It means that Plot Area couldn't be displayed and changed for 3D chars in LibreOffice.
+    // We cannot write Wall attributes into Plot Area for 3D charts, because Wall us used as background wall.
+    if( !mbIs3DChart && xWallFloorSupplier.is() )
     {
         Reference< beans::XPropertySet > xWallPropSet( xWallFloorSupplier->getWall(), uno::UNO_QUERY );
         if( xWallPropSet.is() )


More information about the Libreoffice-commits mailing list