[Libreoffice-commits] core.git: Changes to 'private/jmux/qt5_fixes'

[Jan-Marek Glogowski]

New branch 'private/jmux/qt5_fixes' available with the following commits:
commit 5bbf5a18a1600f746fc44343bd034abaa09bcd1f
Author: Jan-Marek Glogowski <glogow at fbihome.de>
Date:   Tue Feb 20 12:43:02 2018 +0100

    Add missing die and help functions
    
    Change-Id: Ic2e6138b1ba1a8031a80e4e58f468b6c0f7a4de3

commit 78544d3fec0ea2dd4bae6413968133f3ef30d774
Author: Jan-Marek Glogowski <glogow at fbihome.de>
Date:   Tue Feb 20 12:29:37 2018 +0100

    Qt5 some SalLAyout painting support
    
    Don't know the glyphs are missing...
    
    Change-Id: I40834192e712af6190de8df98c10afa54d8c76e4

commit f8ccf817d8b1a0afa7e366d6b6b44942ed810769
Author: Jan-Marek Glogowski <glogow at fbihome.de>
Date:   Tue Feb 20 12:24:12 2018 +0100

    Qt5 minimal "native" file picker
    
    Change-Id: I99d8213d23b09b6cb1e398359ad05c8fa702a8e0

commit d1fc0d31d2557a55d7b0c4f4b93ce94fe862603b
Author: Jan-Marek Glogowski <glogow at fbihome.de>
Date:   Tue Dec 26 15:14:31 2017 +0000

    Refactor CommonSalLayout font handling
    
    Moves all platform specific code from CommonSalLayout into the
    platform specific plugins. This way the vcl library won't depend
    on the Qt5 libraries and the Qt5Font header can be moved into the
    qt5 VCL plugin.
    
    While at it, switch the CommonSalLayouts font reference from the
    FontSelectPattern to the LogicalFontInstance and also add the
    harfbuzz font handling to the instance.
    
    Change-Id: Ida910b8d88837ea949a2f84394ccc0cfae153060

commit fbe8bf8a3812b453405ae7bc396ba2f5e3e76e8b
Author: Jan-Marek Glogowski <glogow at fbihome.de>
Date:   Tue Dec 26 15:58:21 2017 +0100

    Move PhysicalFontFace member of FontSelectPattern
    
    A FontSelectPattern describes a general font request. It can be
    used to find the best matching LogicalFontInstance. The instance
    will be created based on a PhysicalFontFace, which is really a
    factory since commit 8b700794b2746070814e9ff416ecd7bbb1c902e7.
    Following this workflow, this moves the PhysicalFontFace pointer
    to the instance and makes it constant.
    
    Which leaves some special symbol font handling code in the hash
    and instance lookup code path. It used to query the font face
    directly from the instance.
    I'm not sure of the correct handling. The related commits where
    made to fix #i89002#, which has an attached test document.
    
    1. commit 849f618270da313f9339dda29a9f35938434c91d
    2. commit 8c9823d311fdf8092cc75873e4565325d204a658
    
    The document is as broken as it was before the patch. The symbol
    substitution still works, but the 'Q's are missing when displaying
    a symbol font.
    
    I also don't understand all the reinterpret_casts for fake font
    ids. I guess this was used to prevent the crashes I see, where a
    PhysicalFontFace referenced in a valid LogicalFontInstance is
    freed and a later FontId check in the GlyphCache crashes. So this
    now checks for a valid cache instead.
    
    Change-Id: If8ee5a6288e66cfa4c419289fbdd5b5da128c6ea

commit 3e0879b2d85358c7ed522e965c4fc53e500193df
Author: Jan-Marek Glogowski <glogow at fbihome.de>
Date:   Mon Dec 11 20:33:01 2017 +0100

    Add parameter to format-check any commit
    
    Adds a parameter to check-last-commit, so we can check either
    HEAD~<n> or an actual git hash id.
    Still default to the last commit HEAD~0.
    
    Change-Id: Iadcbadddb31c2887c3e0395ceef34b7c006967e4