[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sd/qa
Tamás Zolnai
tamas.zolnai at collabora.com
Thu Feb 22 14:58:19 UTC 2018
sd/qa/unit/tiledrendering/tiledrendering.cxx | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
New commits:
commit 4152ecf98622d81aef50b68c9165292ba244abb9
Author: Tamás Zolnai <tamas.zolnai at collabora.com>
Date: Wed Feb 21 17:47:59 2018 +0100
Add some extra assert to this test case
To find out why this test fails for some linux tinderbox.
Change-Id: I49d1afbbac631abe49378b12b888615e3e0e1bef
Reviewed-on: https://gerrit.libreoffice.org/50121
Reviewed-by: Tamás Zolnai <tamas.zolnai at collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai at collabora.com>
(cherry picked from commit 0a46237093c1750ee69ddb6a365098dc1d06b758)
Reviewed-on: https://gerrit.libreoffice.org/50178
Reviewed-by: Andras Timar <andras.timar at collabora.com>
Tested-by: Andras Timar <andras.timar at collabora.com>
diff --git a/sd/qa/unit/tiledrendering/tiledrendering.cxx b/sd/qa/unit/tiledrendering/tiledrendering.cxx
index 0eabab25fab2..8b7a7ee89293 100644
--- a/sd/qa/unit/tiledrendering/tiledrendering.cxx
+++ b/sd/qa/unit/tiledrendering/tiledrendering.cxx
@@ -1969,9 +1969,7 @@ void SdTiledRenderingTest::testPasteTextOnSlide()
// Load the document.
comphelper::LibreOfficeKit::setActive();
SdXImpressDocument* pXImpressDocument = createDoc("paste_text_onslide.odp");
-
- ViewCallback aView1;
- SfxViewShell::Current()->registerLibreOfficeKitViewCallback(&ViewCallback::callback, &aView1);
+ CPPUNIT_ASSERT(pXImpressDocument);
// select second text object
pXImpressDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, awt::Key::TAB);
@@ -2017,7 +2015,10 @@ void SdTiledRenderingTest::testPasteTextOnSlide()
Scheduler::ProcessEventsToIdle();
// Check the position of the newly added text shape, created for pasted text
- SdrObject* pObject = pXImpressDocument->GetDocShell()->GetViewShell()->GetActualPage()->GetObj(2);
+ SdPage* pActualPage = pXImpressDocument->GetDocShell()->GetViewShell()->GetActualPage();
+ CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(3), pActualPage->GetObjCount());
+ SdrObject* pObject = pActualPage->GetObj(2);
+ CPPUNIT_ASSERT(pObject);
SdrTextObj* pTextObj = dynamic_cast<SdrTextObj*>(pObject);
CPPUNIT_ASSERT(pTextObj);
CPPUNIT_ASSERT_EQUAL(static_cast<sal_uInt16>(OBJ_TEXT), pTextObj->GetObjIdentifier());
More information about the Libreoffice-commits
mailing list