[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/filter/oox/viewsettings.cxx |    2 --
 1 file changed, 2 deletions(-)

New commits:
commit 453e30e668454b7b193772b1dffe719d844ac168
Author: Eike Rathke <erack at redhat.com>
Date:   Tue Feb 27 11:30:11 2018 +0100

    crashtesting: remove wrong assert with tdf114555-2.xlsx
    
    Wrong since
    
        commit 597f7b1f02be79f2443230c963b6d1bb594cffa0
        Date:   Sun Nov 20 02:21:56 2016 +0100
    
            tdf#48140 Replace uno call from worksheethelper.cxx
    
    We are importing a document, so asserting on our own max
    dimensions is wrong.
    
    Wrong is also to compare positions <= MAXCOLCOUNT or
    <= MAXROWCOUNT, if at at all it should had been <= MAXCOL and
    <= MAXROW
    
    Change-Id: I9f3aae061785ab62de7c709e19fc68653f15ed1e
    Reviewed-on: https://gerrit.libreoffice.org/50397
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Jenkins <ci at libreoffice.org>

diff --git a/sc/source/filter/oox/viewsettings.cxx b/sc/source/filter/oox/viewsettings.cxx
index 9a7e1d44f62c..54ae94886566 100644
--- a/sc/source/filter/oox/viewsettings.cxx
+++ b/sc/source/filter/oox/viewsettings.cxx
@@ -534,8 +534,6 @@ void ViewSettings::setSheetViewSettings( sal_Int16 nSheet, const SheetViewModelR
 void ViewSettings::setSheetUsedArea( const ScRange& rUsedArea )
 {
     assert( rUsedArea.IsValid() );
-    assert( rUsedArea.aStart.Col() <= MAXCOLCOUNT );
-    assert( rUsedArea.aStart.Row() <= MAXROWCOUNT );
     maSheetUsedAreas[ rUsedArea.aStart.Tab() ] = rUsedArea;
 }