[Libreoffice-commits] core.git: vcl/source

Miklos Vajna vmiklos at collabora.co.uk
Tue Feb 27 15:34:44 UTC 2018


 vcl/source/helper/errcode.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 905d9b81c933b46d0502f982aad1c2931fae0426
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Tue Feb 27 11:21:19 2018 +0100

    vcl: improve ErrCode std::ostream pretty-printer
    
    Let's say you specify a non-existing export filter during conversion.
    
    Old output:
    
    Error: Please verify input parameters... (SfxBaseModel::impl_store <file:///test.html> failed: 0x81a(Error Area:Io Class:Parameter Code:2074))
    
    New output:
    
    Error: Please verify input parameters... (SfxBaseModel::impl_store <file:///test.html> failed: 0x81a(Error Area:Io Class:Parameter Code:26))
    
    The later (at least) allows going to include/vcl/errcode.hxx, searching
    for Io.*Parameter.*26, and leads to ERRCODE_IO_INVALIDPARAMETER.
    
    Change-Id: Iecfcfa4e805147131fde73cc0b89fa38f6ea61d4
    Reviewed-on: https://gerrit.libreoffice.org/50421
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Tested-by: Jenkins <ci at libreoffice.org>

diff --git a/vcl/source/helper/errcode.cxx b/vcl/source/helper/errcode.cxx
index 9b3af20ed17b..bb8e4eaf09e9 100644
--- a/vcl/source/helper/errcode.cxx
+++ b/vcl/source/helper/errcode.cxx
@@ -138,7 +138,7 @@ VCL_DLLPUBLIC std::ostream& operator<<(std::ostream& os, const ErrCode& err)
                 os << "Compiler";
                 break;
         }
-        os << " Code:" << OUString::number(err.GetRest());
+        os << " Code:" << OUString::number(err.GetRest() & 0xff);
     }
     os << ")";
     return os;


More information about the Libreoffice-commits mailing list