[Libreoffice-commits] core.git: sal/CppunitTest_sal_osl.mk sal/qa

Stephan Bergmann sbergman at redhat.com
Tue Jan 2 20:33:21 UTC 2018


 sal/CppunitTest_sal_osl.mk            |    1 -
 sal/qa/osl/file/osl_old_test_file.cxx |   25 -------------------------
 2 files changed, 26 deletions(-)

New commits:
commit 49e62852c9c59b55ed27dcf433d99f5a65f7d6c0
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Jan 2 16:11:15 2018 +0100

    Remove broken test
    
    ...introduced with 26be5f21cebfe9acad088a1086f97eebdb437b7c "unotools: don't go
    belly-up if temp dir is wrong or empty".  At least Flatpak builds can create a
    /not/found/dir directory just fine.
    
    Change-Id: I73115ac99498ac584be77153ef66bba3036392c3
    Reviewed-on: https://gerrit.libreoffice.org/47267
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sal/CppunitTest_sal_osl.mk b/sal/CppunitTest_sal_osl.mk
index 787dbf96174f..d96ab2d41483 100644
--- a/sal/CppunitTest_sal_osl.mk
+++ b/sal/CppunitTest_sal_osl.mk
@@ -27,7 +27,6 @@ $(eval $(call gb_CppunitTest_add_exception_objects,sal_osl,\
 
 $(eval $(call gb_CppunitTest_use_libraries,sal_osl,\
 	sal \
-	utl \
 ))
 
 # the test uses the library created by Module_DLL
diff --git a/sal/qa/osl/file/osl_old_test_file.cxx b/sal/qa/osl/file/osl_old_test_file.cxx
index fbbefbb03884..f093d5fe1bb8 100644
--- a/sal/qa/osl/file/osl_old_test_file.cxx
+++ b/sal/qa/osl/file/osl_old_test_file.cxx
@@ -32,9 +32,6 @@
 #include <cppunit/extensions/HelperMacros.h>
 #include <cppunit/plugin/TestPlugIn.h>
 
-#include <unotools/tempfile.hxx>
-
-
 namespace osl_test_file
 {
 
@@ -140,30 +137,8 @@ void oldtestfile::test_file_004()
 #endif
 }
 
-class TempFileTest : public CppUnit::TestFixture
-{
-
-public:
-    TempFileTest() {}
-
-    void SetTempNameBaseDirectory()
-    {   // only testing: of not found the directory
-        OUString path = utl::TempFile::SetTempNameBaseDirectory("file:///not/found/dir");
-
-        CPPUNIT_ASSERT_MESSAGE("SetTempNameBaseDirectory must give a empty string back",
-            path.isEmpty());
-    }
-
-
-    CPPUNIT_TEST_SUITE(TempFileTest);
-    CPPUNIT_TEST(SetTempNameBaseDirectory);
-    CPPUNIT_TEST_SUITE_END();
-};
-
-
 } // namespace osl_test_file
 
 CPPUNIT_TEST_SUITE_REGISTRATION( osl_test_file::oldtestfile);
-CPPUNIT_TEST_SUITE_REGISTRATION( osl_test_file::TempFileTest);
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


More information about the Libreoffice-commits mailing list