[Libreoffice-commits] core.git: sc/source
Caolán McNamara
caolanm at redhat.com
Sat Jan 6 19:51:33 UTC 2018
sc/source/filter/xml/xmlstyle.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit c46f28ec8be1cf257ad784375f6f8a3dc17a8f87
Author: Caolán McNamara <caolanm at redhat.com>
Date: Sat Jan 6 15:14:22 2018 +0000
ofz#4982 Integer-overflow
Change-Id: I429d07962acb372be460bee4e1c2b1e05dcce19b
Reviewed-on: https://gerrit.libreoffice.org/47500
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm at redhat.com>
Tested-by: Caolán McNamara <caolanm at redhat.com>
diff --git a/sc/source/filter/xml/xmlstyle.cxx b/sc/source/filter/xml/xmlstyle.cxx
index 31339d42edca..48248c4b51d0 100644
--- a/sc/source/filter/xml/xmlstyle.cxx
+++ b/sc/source/filter/xml/xmlstyle.cxx
@@ -25,6 +25,7 @@
#include <rangeutl.hxx>
#include <unonames.hxx>
+#include <o3tl/safeint.hxx>
#include <xmloff/xmlnmspe.hxx>
#include <xmloff/xmltypes.hxx>
#include <xmloff/families.hxx>
@@ -1530,9 +1531,8 @@ bool XmlScPropHdl_RotateAngle::importXML(
bool bRetval(false);
sal_Int32 nValue;
- if (::sax::Converter::convertNumber(nValue, rStrImpValue))
+ if (::sax::Converter::convertNumber(nValue, rStrImpValue) && !o3tl::checked_multiply<sal_Int32>(nValue, 100, nValue))
{
- nValue *= 100;
rValue <<= nValue;
bRetval = true;
}
More information about the Libreoffice-commits
mailing list