[Libreoffice-commits] core.git: vcl/source

Caolán McNamara caolanm at redhat.com
Tue Jan 9 09:04:23 UTC 2018


 vcl/source/fontsubset/cff.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 088df374f01a28c06c4602f33fea2b717bf403f5
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Jan 8 16:42:46 2018 +0000

    tdf#114704 use of float as intermediate causes out by one on large offsets
    
    table offset integer value of 21281769 is correctly read, but on cast to float
    it is represented as 21281768 and we're off by one when cast back to integer
    later
    
    Change-Id: I5694e14d72c04493ba15cc77485a734498a45468
    Reviewed-on: https://gerrit.libreoffice.org/47607
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/source/fontsubset/cff.cxx b/vcl/source/fontsubset/cff.cxx
index 00b6492ad34c..284242882274 100644
--- a/vcl/source/fontsubset/cff.cxx
+++ b/vcl/source/fontsubset/cff.cxx
@@ -31,7 +31,7 @@ typedef long long S64;
 
 typedef sal_Int32 GlyphWidth;
 
-typedef float RealType;
+typedef double RealType;
 typedef RealType ValType;
 #include <vector>
 


More information about the Libreoffice-commits mailing list