[Libreoffice-commits] online.git: kit/Kit.cpp test/UnitFuzz.cpp wsd/LOOLWSD.cpp

Tor Lillqvist tml at collabora.com
Wed Jan 10 12:01:45 UTC 2018


 kit/Kit.cpp       |    2 +-
 test/UnitFuzz.cpp |    7 -------
 wsd/LOOLWSD.cpp   |    6 ------
 3 files changed, 1 insertion(+), 14 deletions(-)

New commits:
commit 217636ed4472acac4c3dda1a52ded64981cdc6eb
Author: Tor Lillqvist <tml at collabora.com>
Date:   Wed Jan 10 13:44:23 2018 +0200

    Drop meaningless "loolnb" word from a comment, drop two related #if 0 blocks
    
    "loolnb" used to mean the concept of using non-blocking sockets back
    when that was experimental proof-of-concept work in progress, but that
    work has been merged in long ago and there is no neeed for the term
    any longer.
    
    Change-Id: I4c49b625fe8be8892b82115eaaa47bcba0f29500
    Reviewed-on: https://gerrit.libreoffice.org/47699
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
    Tested-by: Michael Meeks <michael.meeks at collabora.com>

diff --git a/kit/Kit.cpp b/kit/Kit.cpp
index 8bb4864c..d3ac6bc9 100644
--- a/kit/Kit.cpp
+++ b/kit/Kit.cpp
@@ -1637,7 +1637,7 @@ private:
                     std::vector<char> vect(size);
                     vect.assign(data, data + size);
 
-                    // TODO loolnb - this is probably wrong...
+                    // TODO this is probably wrong...
                     session->handleMessage(/* fin = */ false, WSOpCode::Binary, vect);
                     return true;
                 }
diff --git a/test/UnitFuzz.cpp b/test/UnitFuzz.cpp
index 075fb110..7d09819f 100644
--- a/test/UnitFuzz.cpp
+++ b/test/UnitFuzz.cpp
@@ -124,13 +124,6 @@ public:
         SocketDisposition & /* disposition */,
         WebSocketHandler & /* socket */) override
     {
-#if 0 // loolnb
-        if (_dist(_mt) < 10) // 1%
-        {
-            std::cerr << "Mangle request URI\n";
-            request.setURI(corruptString(request.getURI()));
-        }
-#endif
         return false;
     }
 };
diff --git a/wsd/LOOLWSD.cpp b/wsd/LOOLWSD.cpp
index adbe06c0..289df5aa 100644
--- a/wsd/LOOLWSD.cpp
+++ b/wsd/LOOLWSD.cpp
@@ -2902,12 +2902,6 @@ void UnitWSD::testHandleRequest(TestRequest type, UnitHTTPServerRequest& /* requ
     switch (type)
     {
     case TestRequest::Client:
-#if 0 // loolnb
-        ClientRequestHandler::handleClientRequest(request, response, LOOLWSD::GenSessionId());
-        break;
-    case TestRequest::Prisoner:
-        PrisonerRequestHandler::handlePrisonerRequest(request, response);
-#endif
         break;
     default:
         assert(false);


More information about the Libreoffice-commits mailing list