[Libreoffice-commits] core.git: include/LibreOfficeKit

[Tor Lillqvist]

 include/LibreOfficeKit/LibreOfficeKit.hxx |    5 +++++
 1 file changed, 5 insertions(+)

New commits:
commit 4e5716b57c4ce75d35c76ea26a16d8d0acadaa76
Author: Tor Lillqvist <tml at collabora.com>
Date:   Wed Jan 10 17:28:20 2018 +0200

    Mention that the getError() semantics are unclear
    
    Change-Id: Ifd5b04cc13085749f0f800bdb69cc3fdd5581916

diff --git a/include/LibreOfficeKit/LibreOfficeKit.hxx b/include/LibreOfficeKit/LibreOfficeKit.hxx
index 310b9cfcee88..e158ee62cab7 100644
--- a/include/LibreOfficeKit/LibreOfficeKit.hxx
+++ b/include/LibreOfficeKit/LibreOfficeKit.hxx
@@ -583,6 +583,11 @@ public:
     }
 
     /// Returns the last error as a string, the returned pointer has to be freed by the caller.
+
+    /// Exact semantics somewhat unclear (sometimes the code clears the string that the next call to
+    /// getError() will return if no error happens in another function, sometimes not), and
+    /// unfortunately cleaning up that is harder than it seems, because of lovely global variables
+    /// and a unit test that uses the LibreOfficeKit API in an untypical manner.
     char* getError()
     {
         return mpThis->pClass->getError(mpThis);