[Libreoffice-commits] dev-tools.git: 2 commits - esc-reporting/esc-analyze.py esc-reporting/esc-report.py esc-reporting/qa-tools.py
Xisco Fauli
anistenis at gmail.com
Thu Jan 11 11:49:52 UTC 2018
esc-reporting/esc-analyze.py | 1
esc-reporting/esc-report.py | 9 ++-
esc-reporting/qa-tools.py | 113 +++++++++++++++++++++----------------------
3 files changed, 64 insertions(+), 59 deletions(-)
New commits:
commit ae655e2ad310c367000ff8e01e259721ee11b50d
Author: Xisco Fauli <anistenis at gmail.com>
Date: Thu Jan 11 12:41:57 2018 +0100
Remove unused variable causing KeyError exception
See: https://redmine.documentfoundation.org/issues/2455
+ Avoid list index out of range
diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index 4925961..734de84 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -308,7 +308,6 @@ def analyze_mentoring():
statList['people'][mail]['gerrit']['reviewName'] = '{} <{}>'.format(row['name'],row['email'])
statList['people'][mail]['isCommitter'] = True
statList['people'][mail]['isContributor'] = True
- x1 = statList['people']['mentoring at documentfoundation.org']
statNewDate = cfg['1yearDate']
statOldDate = cfg['nowDate']
for key, row in gerritData['patch'].items():
diff --git a/esc-reporting/esc-report.py b/esc-reporting/esc-report.py
index f23840d..4cbeeca 100755
--- a/esc-reporting/esc-report.py
+++ b/esc-reporting/esc-report.py
@@ -193,13 +193,18 @@ def report_mentoring():
if i1 == 'cleanup_comments':
print('\n ', end='', file=fp)
print("\n + top 5 contributors:", file=fp)
- for i in range(0, 5):
+ print(statList['reportList']['top10commit'])
+ for i in range(0, len(statList['reportList']['top10commit'])):
+ if i == 5:
+ break
print(' {} made {} patches in 1 month, and {} patches in 1 year'.format(
statList['reportList']['top10commit'][i]['name'],
statList['reportList']['top10commit'][i]['month'],
statList['reportList']['top10commit'][i]['year']), file=fp)
print(" + top 5 reviewers:", file=fp)
- for i in range(0, 5):
+ for i in range(0, len(statList['reportList']['top10review'])):
+ if i == 5:
+ break
print(' {} made {} review comments in 1 month, and {} in 1 year'.format(
statList['reportList']['top10review'][i]['name'],
statList['reportList']['top10review'][i]['month'],
commit 86f546c4a9da52d2483a0272a4900126a8bf54ac
Author: Xisco Fauli <anistenis at gmail.com>
Date: Wed Jan 10 19:36:48 2018 +0100
QA tools: some minor changes
diff --git a/esc-reporting/qa-tools.py b/esc-reporting/qa-tools.py
index 8a15fea..35d490b 100755
--- a/esc-reporting/qa-tools.py
+++ b/esc-reporting/qa-tools.py
@@ -34,7 +34,7 @@ untouchedPeriodDays = 365
inactiveAssignedPeriodDays = 90
-targets_list = ['5.3.7', '5.4.3', '6.0.0']
+targets_list = ['5.4.4', '6.0.0']
periods_list = [30, 60, 90, 180]
@@ -724,22 +724,22 @@ def analyze_bugzilla(statList, bugzillaData, cfg):
if rowStatus == 'UNCONFIRMED' and comments[-1]['creator'] != creatorMail and \
datetime.datetime.strptime(row['last_change_time'], "%Y-%m-%dT%H:%M:%SZ") < cfg['retestPeriod']:
if 'untouchedUnconfirmed' not in lResults:
- lResults['untouchedUnconfirmed'] = [[],[]]
- lResults['untouchedUnconfirmed'][0].append(rowId)
- lResults['untouchedUnconfirmed'][1].append(comments[-1]['creator'])
+ lResults['untouchedUnconfirmed'] = []
+ tup = (rowId, row['last_change_time'])
+ lResults['untouchedUnconfirmed'].append(tup)
elif rowStatus == 'NEEDINFO' and comments[-1]['creator'] == creatorMail and \
- datetime.datetime.strptime(row['last_change_time'], "%Y-%m-%dT%H:%M:%SZ") < cfg['retestPeriod']:
+ datetime.datetime.strptime(row['last_change_time'], "%Y-%m-%dT%H:%M:%SZ") >= cfg['retestPeriod']:
if 'NeedInfoProvided' not in lResults:
- lResults['NeedInfoProvided'] = [[],[]]
- lResults['NeedInfoProvided'][0].append(rowId)
- lResults['NeedInfoProvided'][1].append(comments[-1]['creator'])
+ lResults['NeedInfoProvided'] = []
+ tup = (rowId, row['last_change_time'])
+ lResults['NeedInfoProvided'].append(tup)
else:
if rowStatus == 'UNCONFIRMED' and \
datetime.datetime.strptime(row['last_change_time'], "%Y-%m-%dT%H:%M:%SZ") < cfg['retestPeriod']:
if 'Unconfirmed1Comment' not in lResults:
- lResults['Unconfirmed1Comment'] = [[],[]]
- lResults['Unconfirmed1Comment'][0].append(rowId)
- lResults['Unconfirmed1Comment'][1].append(creatorMail)
+ lResults['Unconfirmed1Comment'] = []
+ tup = (rowId, creatorMail)
+ lResults['Unconfirmed1Comment'].append(tup)
for person in row['cc_detail']:
email = person['email']
@@ -748,71 +748,71 @@ def analyze_bugzilla(statList, bugzillaData, cfg):
if movedToFixed:
if 'movedToFixed' not in lResults:
- lResults['movedToFixed'] = [[],[]]
- lResults['movedToFixed'][0].append(rowId)
- lResults['movedToFixed'][1].append(movedToFixedMail)
+ lResults['movedToFixed'] = []
+ tup = (rowId, movedToFixedMail)
+ lResults['movedToFixed'].append(tup)
if autoConfirmed:
if 'autoConfirmed' not in lResults:
- lResults['autoConfirmed'] = [[],[]]
- lResults['autoConfirmed'][0].append(rowId)
- lResults['autoConfirmed'][1].append(autoConfirmedMail)
+ lResults['autoConfirmed'] = []
+ tup = (rowId, autoConfirmedMail)
+ lResults['autoConfirmed'].append(tup)
if newerVersion and row['version'] != 'unspecified':
if 'newerVersion' not in lResults:
- lResults['newerVersion'] = [[],[]]
- lResults['newerVersion'][0].append(rowId)
- lResults['newerVersion'][1].append(newerVersionMail)
+ lResults['newerVersion'] = []
+ tup = (rowId, newerVersionMail)
+ lResults['newerVersion'].append(tup)
if (isOpen(rowStatus) or rowStatus == 'UNCONFIRMED') and patchAdded:
if 'patchAdded' not in lResults:
- lResults['patchAdded'] = [[],[]]
- lResults['patchAdded'][0].append(rowId)
- lResults['patchAdded'][1].append('')
+ lResults['patchAdded'] = []
+ tup = (rowId, '')
+ lResults['patchAdded'].append(tup)
if crashSignature and not crashSignature.startswith('["'):
if 'crashSignature' not in lResults:
- lResults['crashSignature'] = [[],[]]
- lResults['crashSignature'][0].append(rowId)
- lResults['crashSignature'][1].append('')
+ lResults['crashSignature'] = []
+ tup = (rowId, '')
+ lResults['crashSignature'].append(tup)
if isReopened:
if 'reopened6Months' not in lResults:
- lResults['reopened6Months'] = [[],[]]
- lResults['reopened6Months'][0].append(rowId)
- lResults['reopened6Months'][1].append(reopenerEmail)
+ lResults['reopened6Months'] = []
+ tup = (rowId, reopenerEmail)
+ lResults['reopened6Months'].append(tup)
#In case the reporter assigned the bug to himself at creation time
if addAssigned or (creationDate >= cfg['reportPeriod'] and row['assigned_to'] != 'libreoffice-bugs at lists.freedesktop.org' and \
(rowStatus == 'NEW' or rowStatus == 'UNCONFIRMED')):
if 'addAssigned' not in lResults:
- lResults['addAssigned'] = [[],[]]
- lResults['addAssigned'][0].append(rowId)
- lResults['addAssigned'][1].append(addAssignedMail)
+ lResults['addAssigned'] = []
+ tup = (rowId, addAssignedMail)
+ lResults['addAssigned'].append(tup)
if removeAssigned:
if 'removeAssigned' not in lResults:
- lResults['removeAssigned'] =[[],[]]
- lResults['removeAssigned'][0].append(rowId)
- lResults['removeAssigned'][1].append(removeAssignedMail)
+ lResults['removeAssigned'] = []
+ tup = (rowId, removeAssignedMail)
+ lResults['removeAssigned'].append(tup)
if addAssignee:
if 'addAssignee' not in lResults:
- lResults['addAssignee'] =[[],[]]
- lResults['addAssignee'][0].append(rowId)
- lResults['addAssignee'][1].append(addAssigneeMail)
+ lResults['addAssignee'] =[]
+ tup = (rowId, addAssigneeMail)
+ lResults['addAssignee'].append(tup)
if removeAssignee:
if 'removeAssignee' not in lResults:
- lResults['removeAssignee'] =[[],[]]
- lResults['removeAssignee'][0].append(rowId)
- lResults['removeAssignee'][1].append(removeAssigneeMail)
+ lResults['removeAssignee'] =[]
+ tup = (rowId, removeAssigneeMail)
+ lResults['removeAssignee'].append(tup)
if backPortAdded:
if 'backPortAdded' not in lResults:
- lResults['backPortAdded'] = [[],[]]
- lResults['backPortAdded'][0].append(rowId)
- lResults['backPortAdded'][1].append(backPortAddedMail)
+ lResults['backPortAdded'] = []
+ tup = (rowId, backPortAddedMail)
+ lResults['backPortAdded'].append(tup)
#Check bugs where:
# 1. last comment is done by 'libreoffice-commits at lists.freedesktop.org'
@@ -826,26 +826,26 @@ def analyze_bugzilla(statList, bugzillaData, cfg):
commentDate < cfg['fixBugPingPeriod'] and commentDate >= cfg['fixBugPingDiff'] and \
'easyHack' not in row['keywords']:
if 'fixBugPing' not in lResults:
- lResults['fixBugPing'] = [[],[]]
- lResults['fixBugPing'][0].append(rowId)
- lResults['fixBugPing'][1].append('')
+ lResults['fixBugPing'] = []
+ tup = (rowId, '')
+ lResults['fixBugPing'].append(tup)
if rowStatus == 'ASSIGNED' and \
datetime.datetime.strptime(row['last_change_time'], "%Y-%m-%dT%H:%M:%SZ") < cfg['inactiveAssignedPeriod'] and \
'easyHack' not in row['keywords'] and \
rowId not in cfg['configQA']['ignore']['inactiveAssigned']:
if 'inactiveAssigned' not in lResults:
- lResults['inactiveAssigned'] = [[],[]]
- lResults['inactiveAssigned'][0].append(rowId)
- lResults['inactiveAssigned'][1].append(lastAssignedEmail)
+ lResults['inactiveAssigned'] = []
+ tup = (rowId, lastAssignedEmail)
+ lResults['inactiveAssigned'].append(tup)
elif row['summary'].lower().startswith('[meta]'):
statList['bugs']['metabugAlias'][rowId] = row['alias']
- if not row['alias']:
+ if not row['alias'] and isOpen(row['status']):
if 'emptyAlias' not in lResults:
- lResults['emptyAlias'] = [[],[]]
- lResults['emptyAlias'][0].append(rowId)
- lResults['emptyAlias'][1].append('')
+ lResults['emptyAlias'] = []
+ tup = (rowId, '')
+ lResults['emptyAlias'].append(rowId)
output = ''
for k, v in statList['dupesBugs'].items():
@@ -866,8 +866,9 @@ def analyze_bugzilla(statList, bugzillaData, cfg):
for dKey, dValue in lResults.items():
if dValue:
print('\n=== ' + dKey + ' ===')
- for idx in range(len(dValue[0])):
- print(str(idx + 1) + ' - ' + urlShowBug + str(dValue[0][idx]) + " - " + str(dValue[1][idx]))
+ dValue = sorted(dValue, key=lambda x: x[1])
+ for idx in range(len(dValue)):
+ print(str(idx + 1) + ' - ' + urlShowBug + str(dValue[idx][0]) + " - " + str(dValue[idx][1]))
for k, v in statList['people'].items():
if not statList['people'][k]['name']:
More information about the Libreoffice-commits
mailing list