[Libreoffice-commits] core.git: cppuhelper/source

[Stephan Bergmann]

 cppuhelper/source/shlib.cxx |    8 --------
 1 file changed, 8 deletions(-)

New commits:
commit 7f063b77da6db00806d9e6c60239a59d75ae3cee
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Fri Jan 12 10:23:49 2018 +0100

    Revert "Print the important failure messages on iOS even in a non-debug build"
    
    This reverts commit ab07f81d0b5ffc4297d5f15d2458c5cc9217800f.
    
    > Jan 12 10:21:35 <sberg> tml_, is ab07f81d0b5ffc4297d5f15d2458c5cc9217800f
    >  still relevant? (one could imagine that if one wants such debug output during
    > development in a non-debug build, one could build with --enable-sal-log?)
    > Jan 12 10:22:01 <tml_> I have no idea what's relevant on iOS any longer
    > Jan 12 10:22:26 <tml_> ... but my gut feeling would be no, can be removed
    > Jan 12 10:23:14 <tml_> the rationale in the commit message sounds a bit thin
    > Jan 12 10:24:02 <tml_> surely one should test an ap well enough before
    >  submitting, to verify that it isn't possible to get it to try to invoke a
    >  constructor that isn't included
    
    Change-Id: I20ce8aa40a00205c1cae9d6ed4a87a6093745dc4
    Reviewed-on: https://gerrit.libreoffice.org/47791
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/cppuhelper/source/shlib.cxx b/cppuhelper/source/shlib.cxx
index e78071bb4774..52d8af821474 100644
--- a/cppuhelper/source/shlib.cxx
+++ b/cppuhelper/source/shlib.cxx
@@ -266,10 +266,6 @@ void cppuhelper::detail::loadSharedLibComponentFactory(
         }
         if (fp == 0) {
             SAL_WARN("cppuhelper", "unknown factory name \"" << name << "\"");
-#if defined IOS && !defined SAL_LOG_WARN
-            // If the above SAL_WARN expanded to nothing, print to stderr...
-            fprintf(stderr, "Unknown factory name %s\n", OUStringToOString(name, RTL_TEXTENCODING_UTF8).getStr());
-#endif
             throw css::loader::CannotActivateFactoryException(
                 "unknown factory name \"" + name + "\"",
                 css::uno::Reference<css::uno::XInterface>());
@@ -290,10 +286,6 @@ void cppuhelper::detail::loadSharedLibComponentFactory(
             }
         }
         SAL_WARN("cppuhelper", "unknown constructor name \"" << constructor << "\"");
-#if defined IOS && !defined SAL_LOG_WARN
-            // If the above SAL_WARN expanded to nothing, print to stderr...
-            fprintf(stderr, "Unknown constructor name %s\n", OUStringToOString(constructor, RTL_TEXTENCODING_UTF8).getStr());
-#endif
         throw css::loader::CannotActivateFactoryException(
             "unknown constructor name \"" + constructor + "\"",
             css::uno::Reference<css::uno::XInterface>());