[Libreoffice-commits] core.git: sal/rtl

[Michael Stahl]

 sal/rtl/digest.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 665ffc01e124029dc1412cc31e67878f697902ac
Author: Michael Stahl <mstahl at redhat.com>
Date:   Wed Jan 17 11:11:01 2018 +0100

    tdf#114939 sal: document the bug in endSHA()
    
    Change-Id: I58df3705c1e07737747b6f8e3ce91d5278018cbb

diff --git a/sal/rtl/digest.cxx b/sal/rtl/digest.cxx
index e3db60461d5e..fbacbc9838dd 100644
--- a/sal/rtl/digest.cxx
+++ b/sal/rtl/digest.cxx
@@ -1047,6 +1047,8 @@ static void endSHA(DigestContextSHA *ctx)
 
     i += 1;
 
+    // tdf#114939 NB: this is WRONG and should be ">" not ">=" but is not
+    // fixed as this buggy SHA1 implementation is needed for compatibility
     if (i >= (DIGEST_LBLOCK_SHA - 2))
     {
         for (; i < DIGEST_LBLOCK_SHA; i++)