[Libreoffice-commits] core.git: test/source

Stephan Bergmann sbergman at redhat.com
Sat Jan 20 09:45:48 UTC 2018


 test/source/sheet/spreadsheetviewsettings.cxx |    2 --
 1 file changed, 2 deletions(-)

New commits:
commit 0b87fdcad55d1927241073bc15c174168c5e0c1d
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Fri Jan 19 17:38:25 2018 +0100

    Remove dubious test
    
    ...that fails for me on at least one macOS and Windows machine each (with 180
    and 230, resp., instead of 116), and where it is unclear why only a value of 116
    would be correct (and where that specific check was not present before
    95307f2ca73480176634e5cc46d96a19b735e87b "tdf#45904 Move
    _SpreadsheetViewSettings Java tests to C++", cf. my comment from 2018-01-17 at
    <https://gerrit.libreoffice.org/#/c/47625/> "tdf#45904 Move
    _SpreadsheetViewSettings Java tests to C++")
    
    Change-Id: I16475ecaa853220ffe9e1d6dcf403302b04f4572
    Reviewed-on: https://gerrit.libreoffice.org/48215
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/test/source/sheet/spreadsheetviewsettings.cxx b/test/source/sheet/spreadsheetviewsettings.cxx
index 9fb5d274f0d2..68f1d043d235 100644
--- a/test/source/sheet/spreadsheetviewsettings.cxx
+++ b/test/source/sheet/spreadsheetviewsettings.cxx
@@ -230,8 +230,6 @@ void SpreadsheetViewSettings::testSpreadsheetViewSettingsProperties()
     propName = "ZoomValue";
     sal_Int16 aZoomValue = 42;
     CPPUNIT_ASSERT(xSpreadsheetViewSettings->getPropertyValue(propName) >>= aZoomValue);
-    CPPUNIT_ASSERT_EQUAL_MESSAGE("Unable to get PropertyValue ZoomValue", sal_Int16(116),
-                                 aZoomValue);
 
     aNewValue <<= sal_Int16(1);
     xSpreadsheetViewSettings->setPropertyValue(propName, aNewValue);


More information about the Libreoffice-commits mailing list