[Libreoffice-commits] core.git: vcl/source

Stephan Bergmann sbergman at redhat.com
Mon Jan 22 10:38:30 UTC 2018


 vcl/source/gdi/bitmap4.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 50833efae43cf801ae602ccf30b431cc4c90275c
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Jan 16 16:15:08 2018 +0100

    Presumably misplaced cast
    
    ...that was originally introduced as
    
      int intRadius = (int) radius + 1.0;
    
    in 05363527d84119c6759cdd638c76b041f2aa67b7 "Separable Gaussian Blur and
    Unsharpen Mask filter", and presumably was meant to cover the whole right-hand-
    side addition, not just "radius".
    
    Change-Id: I3c14f4055e74e3e4dcccbddce060a86f9bcc23f0
    Reviewed-on: https://gerrit.libreoffice.org/48005
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Tomaž Vajngerl <quikee at gmail.com>

diff --git a/vcl/source/gdi/bitmap4.cxx b/vcl/source/gdi/bitmap4.cxx
index 9400f4d61e2b..50eb1853d8c2 100644
--- a/vcl/source/gdi/bitmap4.cxx
+++ b/vcl/source/gdi/bitmap4.cxx
@@ -1043,7 +1043,7 @@ bool Bitmap::ImplPopArt()
 }
 
 double* MakeBlurKernel(const double radius, int& rows) {
-    int intRadius = static_cast<int>(radius) + 1.0;
+    int intRadius = static_cast<int>(radius + 1.0);
     rows = intRadius * 2 + 1;
     double* matrix = new double[rows];
 


More information about the Libreoffice-commits mailing list