[Libreoffice-commits] core.git: xmlreader/source

Stephan Bergmann sbergman at redhat.com
Tue Jan 23 13:23:13 UTC 2018


 xmlreader/source/xmlreader.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a6b53b5461c7d1ad2895d25691661f865bdb183e
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Jan 23 14:17:03 2018 +0100

    Silence -Werror=implicit-fallthrough= (upcoming GCC 8)
    
    Earlier GCC already require a similar workaround to silence -Werror=return-type
    ("control reaches end of non-void function") a few lines further down, so it's
    rather consequential that GCC now also warns about the potential fall-through
    here (i.e., for these warnings, GCC apparently assumes that an enum can take on
    all of the values from its range of values, not just those denoted by an
    enumerator).
    
    Change-Id: I1537a7f6975f900861225ee7a521366a5e57046a

diff --git a/xmlreader/source/xmlreader.cxx b/xmlreader/source/xmlreader.cxx
index d6fe61f8363f..8e544b6a07d0 100644
--- a/xmlreader/source/xmlreader.cxx
+++ b/xmlreader/source/xmlreader.cxx
@@ -134,7 +134,7 @@ XmlReader::Result XmlReader::nextItem(Text reportText, Span * data, int * nsId)
             return handleSkippedText(data, nsId);
         case Text::Raw:
             return handleRawText(data);
-        case Text::Normalized:
+        default: // Text::Normalized
             return handleNormalizedText(data);
         }
     case State::StartTag:


More information about the Libreoffice-commits mailing list