[Libreoffice-commits] core.git: vcl/source

Caolán McNamara caolanm at redhat.com
Wed Jan 24 17:22:32 UTC 2018


 vcl/source/window/seleng.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a283847a95dd8935dec687d91709604d96636a34
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Jan 24 17:18:35 2018 +0000

    gtk3: single click with selection set doesn't unselect
    
    this is a safe backportable fix, the unconditional
    
    nFlags |= SelectionEngineFlags::CMDEVT
    
    looks the real dubious thing to me, but only the gtk3 backend has swipe support
    so just returning immediately on a swipe definitely ok
    
    Change-Id: Iade26d0d9260ce76dfb2766ac9e5ca9fa9275bf4
    Reviewed-on: https://gerrit.libreoffice.org/48527
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/source/window/seleng.cxx b/vcl/source/window/seleng.cxx
index c911a9059551..c545824436cd 100644
--- a/vcl/source/window/seleng.cxx
+++ b/vcl/source/window/seleng.cxx
@@ -342,7 +342,7 @@ void SelectionEngine::Reset()
 void SelectionEngine::Command( const CommandEvent& rCEvt )
 {
     // Timer aWTimer is active during enlarging a selection
-    if ( !pFunctionSet || !pWin || aWTimer.IsActive() )
+    if ( !pFunctionSet || !pWin || aWTimer.IsActive() || rCEvt.GetCommand() == CommandEventId::Swipe )
         return;
     aWTimer.Stop();
     nFlags |= SelectionEngineFlags::CMDEVT;


More information about the Libreoffice-commits mailing list