[Libreoffice-commits] core.git: compilerplugins/clang xmloff/source

Noel Grandin noel.grandin at collabora.co.uk
Thu Jan 25 08:52:09 UTC 2018


 compilerplugins/clang/datamembershadow.cxx |    2 --
 xmloff/source/draw/ximplink.hxx            |    1 -
 2 files changed, 3 deletions(-)

New commits:
commit 97b7ada0388d0b0da4303cf95443339ab0f3523b
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Wed Jan 24 14:54:19 2018 +0200

    loplugin:datamembershadow in SdXMLShapeLinkContext
    
    in this case, we can just drop the child member and re-use the parent
    member. The parent class barely contains any logic anyway.
    
    Change-Id: I520217c04a38b66323a76bf5fddb476bd3fc8e15
    Reviewed-on: https://gerrit.libreoffice.org/48551
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/datamembershadow.cxx b/compilerplugins/clang/datamembershadow.cxx
index 040743bad028..520e1195f0ca 100644
--- a/compilerplugins/clang/datamembershadow.cxx
+++ b/compilerplugins/clang/datamembershadow.cxx
@@ -90,8 +90,6 @@ bool DataMemberShadow::VisitFieldDecl(FieldDecl const * fieldDecl)
         return true;
     if (loplugin::isSamePathname(aFileName, SRCDIR "/vcl/unx/generic/print/genpspgraphics.cxx"))
         return true;
-    if (loplugin::isSamePathname(aFileName, SRCDIR "/xmloff/source/draw/ximplink.hxx"))
-        return true;
 
     const CXXRecordDecl* parentCXXRecordDecl = dyn_cast<CXXRecordDecl>(fieldDecl->getDeclContext());
     if (!parentCXXRecordDecl) {
diff --git a/xmloff/source/draw/ximplink.hxx b/xmloff/source/draw/ximplink.hxx
index c930f9b0f7e7..3a52244cb7e2 100644
--- a/xmloff/source/draw/ximplink.hxx
+++ b/xmloff/source/draw/ximplink.hxx
@@ -35,7 +35,6 @@ class SdXMLShapeLinkContext : public SvXMLShapeContext
 {
     // the parent shape group this link is placed in
     css::uno::Reference< css::drawing::XShapes > mxParent;
-    OUString msHyperlink;
 
 public:
 


More information about the Libreoffice-commits mailing list