[Libreoffice-commits] core.git: sc/source

Eike Rathke erack at redhat.com
Fri Jan 26 13:04:20 UTC 2018


 sc/source/ui/unoobj/cellsuno.cxx |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 09b81a42c2689b7249c8c39899c0b5b36c050306
Author: Eike Rathke <erack at redhat.com>
Date:   Fri Jan 26 14:01:12 2018 +0100

    coverity#1428611 check for nullptr
    
    Change-Id: I4d0bd765e4c1677448dcd3a74f26f36394c4a358

diff --git a/sc/source/ui/unoobj/cellsuno.cxx b/sc/source/ui/unoobj/cellsuno.cxx
index 2731e69cfc79..8cee317d4f8b 100644
--- a/sc/source/ui/unoobj/cellsuno.cxx
+++ b/sc/source/ui/unoobj/cellsuno.cxx
@@ -6418,7 +6418,11 @@ sal_Int32 ScCellObj::GetResultType_Impl()
         if (pDocSh->GetDocument().GetCellType(aCellPos) == CELLTYPE_FORMULA)
         {
             ScFormulaCell* pFCell = pDocSh->GetDocument().GetFormulaCell(aCellPos);
-            if (pFCell->GetErrCode() != FormulaError::NONE )
+            if (!pFCell)
+            {
+                // should throw instead of default string?
+            }
+            else if (pFCell->GetErrCode() != FormulaError::NONE )
             {
                 eRet = sheet::FormulaResult::ERROR;
             }


More information about the Libreoffice-commits mailing list