[Libreoffice-commits] core.git: editeng/source

Stephan Bergmann sbergman at redhat.com
Sun Jan 28 20:48:11 UTC 2018


 editeng/source/accessibility/AccessibleEditableTextPara.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e120409015296ad8386502d61273c03c58eda3ad
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Sun Jan 28 11:01:55 2018 +0100

    nStart/EndEEIndex nned not be bounded by sal_uInt16
    
    ...it appears, since ESelection's nStart/EndPos have been changed to sal_Int32
    with 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5 "xub_StrLen and tools/string.hxx
    final straw".
    
    Change-Id: I3f3d77d6efeabef9f05b3a5233e0e5590b1ed365
    Reviewed-on: https://gerrit.libreoffice.org/48767
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/editeng/source/accessibility/AccessibleEditableTextPara.cxx b/editeng/source/accessibility/AccessibleEditableTextPara.cxx
index 6f4aa8791ffd..c555deae0ab3 100644
--- a/editeng/source/accessibility/AccessibleEditableTextPara.cxx
+++ b/editeng/source/accessibility/AccessibleEditableTextPara.cxx
@@ -339,8 +339,8 @@ namespace accessibility
     ESelection AccessibleEditableTextPara::MakeSelection( sal_Int32 nStartEEIndex, sal_Int32 nEndEEIndex )
     {
         // check overflow
-        DBG_ASSERT(nStartEEIndex >= 0 && nStartEEIndex <= USHRT_MAX &&
-                   nEndEEIndex >= 0 && nEndEEIndex <= USHRT_MAX &&
+        DBG_ASSERT(nStartEEIndex >= 0 &&
+                   nEndEEIndex >= 0 &&
                    GetParagraphIndex() >= 0 && GetParagraphIndex() <= SAL_MAX_INT32,
                    "AccessibleEditableTextPara::MakeSelection: index value overflow");
 


More information about the Libreoffice-commits mailing list