[Libreoffice-commits] core.git: sw/source

Stephan Bergmann sbergman at redhat.com
Wed Jan 31 11:05:30 UTC 2018


 sw/source/filter/ww8/wrtww8.hxx |    2 +-
 sw/source/filter/ww8/ww8atr.cxx |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f941cd78a0f805b968bac65fc7c3ef4efffe10fc
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Wed Jan 31 08:58:32 2018 +0100

    SvxNumberFormat::GetAbsLSpace returns short...
    
    ...(and both calls of CorrectTabStopInSet pass in the result of a GetAbsLSpace
    call), and SvxTabStop::GetTabPos() is sal_Int32& (and that's what nAbsLeft is
    combined with inside CorrectTabStopInSet), so why use an intermediary parameter
    of type sal_uInt16?
    
    Change-Id: I1cd1869ead58c419eecb3e2d1fbfb87f96bca86f
    Reviewed-on: https://gerrit.libreoffice.org/48956
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sw/source/filter/ww8/wrtww8.hxx b/sw/source/filter/ww8/wrtww8.hxx
index 1336fc9e2dc3..2b39a7d887d5 100644
--- a/sw/source/filter/ww8/wrtww8.hxx
+++ b/sw/source/filter/ww8/wrtww8.hxx
@@ -883,7 +883,7 @@ public:
 
     // TODO move as much as possible here from WW8Export! ;-)
 
-    static void CorrectTabStopInSet( SfxItemSet& rSet, sal_uInt16 nAbsLeft );
+    static void CorrectTabStopInSet( SfxItemSet& rSet, short nAbsLeft );
 
 private:
     MSWordExportBase( const MSWordExportBase& ) = delete;
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index 3ccd047b620b..e569ec0a0904 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -642,7 +642,7 @@ void WW8Export::PrepareNewPageDesc( const SfxItemSet*pSet,
     }
 }
 
-void MSWordExportBase::CorrectTabStopInSet( SfxItemSet& rSet, sal_uInt16 nAbsLeft )
+void MSWordExportBase::CorrectTabStopInSet( SfxItemSet& rSet, short nAbsLeft )
 {
     if (const SvxTabStopItem *pItem = rSet.GetItem<SvxTabStopItem>(RES_PARATR_TABSTOP))
     {


More information about the Libreoffice-commits mailing list