[Libreoffice-commits] online.git: Branch 'distro/collabora/collabora-online-3-0' - common/Util.cpp

Henry Castro hcastro at collabora.com
Wed Jan 31 22:00:16 UTC 2018


 common/Util.cpp |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit b91d38ad501c80cf06537b77cec5738b7adee88a
Author: Henry Castro <hcastro at collabora.com>
Date:   Wed Jan 31 15:31:44 2018 -0400

    util: avoid logging when closing file descriptors
    
    eventually the log file descriptor will be closed and unhandled exception it will throw it
    
    "terminate called after throwing an instance of 'Poco::WriteFileException'
      what():  Cannot write file"
    
    Change-Id: I1d6ae3a4d4d4910f2ed2cdc80b162c27f93d55d9
    Reviewed-on: https://gerrit.libreoffice.org/49055
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
    Tested-by: Michael Meeks <michael.meeks at collabora.com>
    Reviewed-on: https://gerrit.libreoffice.org/49064

diff --git a/common/Util.cpp b/common/Util.cpp
index a82c54ea..357f6da8 100644
--- a/common/Util.cpp
+++ b/common/Util.cpp
@@ -142,9 +142,7 @@ namespace Util
                   continue;
 
               if (close(fd) < 0)
-                  LOG_WRN("Unexpected failure to close fd " << fd);
-              else
-                  LOG_TRC("Closed fd " << fd);
+                  std::cerr << "Unexpected failure to close fd " << fd << std::endl;
           }
 
           closedir(fdDir);


More information about the Libreoffice-commits mailing list