[Libreoffice-commits] core.git: sd/source

Stephan Bergmann sbergman at redhat.com
Tue Jul 3 12:51:10 UTC 2018


 sd/source/ui/view/drviewsa.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 11efed740ef5fb96485fe007639f9a0df2b2c28e
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Jul 3 11:43:14 2018 +0200

    Read of uninitialized DrawViewShell::mbMouseButtonDown
    
    ... (introduced with 6fffd09833a5bd602b0117f48656afd07fd40f41 "tdf#109190 sd:
    only MakeVisible on mouseclick-up") during CppunitTest_sd_misc_tests,
    <https://ci.libreoffice.org//job/lo_ubsan/960/console>:
    
    > /sd/source/ui/inc/DrawViewShell.hxx:117:50: runtime error: load of value 190, which is not a valid value for type 'bool'
    >     #0 0x2b20592e1a9c in sd::DrawViewShell::IsMouseButtonDown() /sd/source/ui/inc/DrawViewShell.hxx:117:50
    >     #1 0x2b20594e7c0c in sd::DrawViewShell::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drviewsh.cxx:61:11
    >     #2 0x2b2059074b41 in sd::DrawView::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drawview.cxx:501:9
    >     #3 0x2b207669a227 in SdrObjEditView::ImpMakeTextCursorAreaVisible() /svx/source/svdraw/svdedxv.cxx:1959:17
    >     #4 0x2b20766e4ea4 in SdrObjEditView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdedxv.cxx:2171:13
    >     #5 0x2b2076396e58 in SdrCreateView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdcrtv.cxx:868:16
    >     #6 0x2b203f8d7b36 in SdrView::SetAttributes(SfxItemSet const&, bool) /include/svx/svdview.hxx:192:81
    >     #7 0x2b203f8ab5a1 in SdMiscTest::testTdf99396TextEdit() /sd/qa/unit/misc-tests.cxx:215:9
    >     #8 0x2b203f934ad8 in void std::_Mem_fn_base<void (SdMiscTest::*)(), true>::operator()<, void>(SdMiscTest*) const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:600:11
    >     #9 0x2b203f9347e3 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1073:11
    >     #10 0x2b203f9341f1 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::operator()<, void>() /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1131:11
    >     #11 0x2b203f932bc9 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1871:2
    >     #12 0x2b203f935550 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:2271:14
    >     #13 0x2b203f931265 in CppUnit::TestCaller<SdMiscTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7
    >     #14 0x2b1ff4edce7d in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5
    >     #15 0x2b20120c14d6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:48:14
    >     #16 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
    >     #17 0x2b20048ad7a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12
    >     #18 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
    >     #19 0x2b2000939e13 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16
    >     #20 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
    >     #21 0x2b1ff4e172df in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12
    >     #22 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12
    >     #23 0x2b1ff4e91b70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18
    >     #24 0x2b1ff4f66ccb in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:10
    >     #25 0x2b1ff4ed9efd in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5
    >     #26 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
    >     #27 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
    >     #28 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5
    >     #29 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3
    >     #30 0x2b1ff4fa6686 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5
    >     #31 0x2b1ff4f64e19 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:3
    >     #32 0x2b1ff4fa7b27 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:3
    >     #33 0x515d6d in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:315:13
    >     #34 0x51071f in sal_main() /sal/cppunittester/cppunittester.cxx:465:14
    >     #35 0x50e832 in main /sal/cppunittester/cppunittester.cxx:372:1
    >     #36 0x2b1ff6bdc444 in __libc_start_main (/lib64/libc.so.6+0x22444)
    >     #37 0x433494 in _start (/workdir/LinkTarget/Executable/cppunittester+0x433494)
    
    Change-Id: Idff283298ee2fa11467ff4b8604da642e5a09a8f
    Reviewed-on: https://gerrit.libreoffice.org/56854
    Reviewed-by: Justin Luth <justin_luth at sil.org>
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sd/source/ui/view/drviewsa.cxx b/sd/source/ui/view/drviewsa.cxx
index 924b274af28c..31ada8f087e0 100644
--- a/sd/source/ui/view/drviewsa.cxx
+++ b/sd/source/ui/view/drviewsa.cxx
@@ -113,6 +113,8 @@ DrawViewShell::DrawViewShell( ViewShellBase& rViewShellBase, vcl::Window* pParen
           [this] () { return this->GetSidebarContextName(); },
           uno::Reference<frame::XController>(&rViewShellBase.GetDrawController()),
           vcl::EnumContext::Context::Default))
+    , mbMouseButtonDown(false)
+    , mbMouseSelecting(false)
 {
     if (pFrameViewArgument != nullptr)
         mpFrameView = pFrameViewArgument;


More information about the Libreoffice-commits mailing list